8000 fix(scanner): fix displayArtist logic by deluan · Pull Request #3835 · navidrome/navidrome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(scanner): fix displayArtist logic #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

fix(scanner): fix displayArtist logic #3835

merged 4 commits into from
Mar 17, 2025

Conversation

deluan
Copy link
Member
@deluan deluan commented Mar 16, 2025 •
edited
Loading

Should fix #3808

Rules:

  • ARTIST(S) tags No ARTIST/ARTISTS tags should set the display name to Unknown Artist
  • ARTIST(S) tags No ARTIST/ARTISTS tags should set artist to Unknown Artist
  • ARTIST(S) tags No ARTIST/ARTISTS tags should add an Unknown Artist to participants
  • ARTIST(S) tags Single-valued ARTIST tags, no ARTISTS tags should use the artist tag as display name
  • ARTIST(S) tags Single-valued ARTIST tags, no ARTISTS tags should populate the participants
  • ARTIST(S) tags Multiple values in a Single-valued ARTIST tags, no ARTISTS tags should use the full string as display name
  • ARTIST(S) tags Multiple values in a Single-valued ARTIST tags, no ARTISTS tags should split the tag
  • ARTIST(S) tags Multiple values in a Single-valued ARTIST tags, no ARTISTS tags should split the tag using case-insensitive separators
  • ARTIST(S) tags Multiple values in a Single-valued ARTIST tags, no ARTISTS tags should not add an empty artist after split
  • ARTIST(S) tags Multi-valued ARTIST tags, no ARTISTS tags should concatenate all ARTIST values as display name
  • ARTIST(S) tags Multi-valued ARTIST tags, no ARTISTS tags should populate the participants with all artists
  • ARTIST(S) tags Single-valued ARTIST tag, single-valued ARTISTS tag, same values should use the ARTIST tag as display name
  • ARTIST(S) tags Single-valued ARTIST tag, single-valued ARTISTS tag, same values should populate the participants with the ARTIST
  • ARTIST(S) tags Single-valued ARTIST tag, single-valued ARTISTS tag, different values should use the ARTIST tag as display name
  • ARTIST(S) tags Single-valued ARTIST tag, single-valued ARTISTS tag, different values should use only artists from ARTISTS
  • ARTIST(S) tags No ARTIST tag, multi-valued ARTISTS tag should concatenate ARTISTS as display name
  • ARTIST(S) tags No ARTIST tag, multi-valued ARTISTS tag should populate the participants with all artists
  • ARTIST(S) tags Single-valued ARTIST tags, multi-valued ARTISTS tags should use the single-valued tag as display name
  • ARTIST(S) tags Single-valued ARTIST tags, multi-valued ARTISTS tags should prioritize multi-valued tags over single-valued tags
  • ARTIST(S) tags Multi-valued ARTIST tags, multi-valued ARTISTS tags should use ARTIST values concatenated as a display name
  • ARTIST(S) tags Multi-valued ARTIST tags, multi-valued ARTISTS tags should prioritize ARTISTS tags

8000
@deluan
fix displayArtist logic
436c134 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan deluan mentioned this pull request Mar 16, 2025
Closed
3 tasks
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 16, 2025 •
edited
Loading

Download the artifacts for this pull request:

deluan added 3 commits March 16, 2025 13:55
@deluan
remove unneeded value
36f032d 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
refactor
01e16ef 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan
Use first albumartist if it cannot figure out the display name
ab28c78 
Signed-off-by: Deluan <deluan@navidrome.org>
@deluan deluan merged commit 2adb098 into master Mar 17, 2025
34 checks passed
@deluan deluan deleted the display-artists branch March 17, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Album Artist aren't parsed correctly
1 participant
@deluan
0