Fix #3902: Make first user created via reverse proxy an admin #3920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roxy Fix #3902 Signed-off-by: Deluan <deluan@navidrome.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3902 - When Navidrome is accessed for the first time through a reverse proxy with authentication headers (Remote-User), it creates a regular non-admin user. This prevents the normal "first user is admin" flow, leaving the system without an admin user.
Changes
handleLoginFromHeadersfunction inserver/auth.goto check if there are any existing users before creating a new userTesting
Added new test cases to verify:
This change maintains consistent behavior with manual user creation where the first user is always an admin.