8000 Feature/Added --list-services argument. by JJmako · Pull Request #671 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/Added --list-services argument. #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 20, 2020
Merged

Feature/Added --list-services argument. #671

merged 7 commits into from
Mar 20, 2020

Conversation

JJmako
Copy link
Contributor
@JJmako JJmako commented Mar 16, 2020 •
edited by x4v13r64
Loading

Added --list_services argument, to resolve #467.

With this option, all possible services are listed.

@x4v13r64 x4v13r64 changed the base branch from develop to master March 16, 2020 12:19
@x4v13r64 x4v13r64 changed the base branch from master to develop March 16, 2020 12:19
@lgtm-com
Copy link
lgtm-com bot commented Mar 16, 2020

This pull request introduces 1 alert when merging 77c33f7 into 6cadac7 - view on LGTM.com

new alerts:

  • 1 for Unused import

@JJmako JJmako changed the title Added all findings Feature/Added --list_services argument. Mar 17, 2020
@x4v13r64
Copy link
Collaborator

@JJmako the current implementation requires authentication. would it be possible to implement it similarly to --version?

@JJmako
Copy link
Contributor Author
JJmako commented Mar 18, 2020

@JJmako the current implementation requires authentication. would it be possib 8000 le to implement it similarly to --version?

I have been chasing this. You need to authenticate to retrieve the services. If I do a parameter similar to --version I have to mock the services in a file.
If the services are always the same, this is a good solution, but if providers change their services this file have to change.

@x4v13r64
Copy link
Collaborator

You need to authenticate to retrieve the services.

I believe you're right. I thought you could just instantiate a facade or ServiceConfig object and look at its attributes, but those require credentials to build.

Therefore I think your approach is correct, I'll review and merge 👍

@x4v13r64 x4v13r64 self-requested a review March 19, 2020 19:13
@codecov-io
Copy link
codecov-io commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #671 into develop will decrease coverage by 0.14%.
The diff coverage is 1.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #671      +/-   ##
===========================================
- Coverage    65.21%   65.06%   -0.15%     
===========================================
  Files           22       22              
  Lines         1515     1520       +5     
===========================================
+ Hits           988      989       +1     
- Misses         527      531       +4
Impacted Files Coverage Δ
ScoutSuite/__init__.py 100.00% <ø> (ø)
ScoutSuite/__main__.py 19.04% <0.00%> (-0.76%) ⬇️
ScoutSuite/core/conditions.py 89.68% <ø> (ø)
ScoutSuite/core/console.py 65.07% <ø> (ø)
ScoutSuite/core/exceptions.py 27.77% <ø> (ø)
ScoutSuite/core/fs.py 71.92% <ø> (ø)
ScoutSuite/core/processingengine.py 82.35% <ø> (ø)
ScoutSuite/core/rule.py 95.78% <ø> (ø)
ScoutSuite/core/rule_definition.py 67.64% <ø> (ø)
ScoutSuite/core/ruleset.py 75.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f6316...5fedd20. Read the comment docs.

@x4v13r64 x4v13r64 linked an issue Mar 20, 2020 that may be closed by this pull request
Feature Request - List supported services #467
Closed
@x4v13r64 x4v13r64 changed the title Feature/Added --list_services argument. Feature/Added --list-services argument. Mar 20, 2020
@JJmako JJmako merged commit 235be34 into develop Mar 20, 2020
@JJmako JJmako deleted the feature/list_supported_services branch March 20, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4v13r64 x4v13r64 x4v13r64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request - List supported services
3 participants
@JJmako @x4v13r64 @codecov-io
0