8000 release/5.9.0 by x4v13r64 · Pull Request #696 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

release/5.9.0 #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 324 commits into from
Jul 2, 2020
Merged

release/5.9.0 #696

merged 324 commits into from
Jul 2, 2020

Conversation

x4v13r64
Copy link
Collaborator
@x4v13r64 x4v13r64 commented Apr 2, 2020 •
edited
Loading

Changes:

  • Improved provider support:
    • AWS
      • Added 4 new ELB & ELBv2 findings (thanks to @goelaarushi04)
      • Added support for the "Amazon S3 Block Public Access" feature
      • Improved Lambda partial
      • Added support for RDS Aurora instances
    • Azure
      • Improved the authentication flow, and handling of subscriptions
    • GCP
      • Added support for Stackdriver Monitoring
      • Improved report content
      • Merged IAM & Resource Manager services
      • Added logic that validates if an API is enabled for a service & project prior to making additional API calls
  • Updated the rule format, to allow remediation & compliance information, as well as external references
  • Added an option in the report (top-right menu) to export a high level finding summary
  • Added a tool/util to upload findings to AWS Security Hub (see https://github.com/nccgroup/ScoutSuite/tree/develop/tools#aws_security_hub_exportpy)
  • Improved open source project public content
  • Bug fixes

Release pre-requisites:

  • Test and update AWS minimal policy
  • Update AWS IPs

@x4v13r64 x4v13r64 changed the title Develop release/5.9.0 Apr 2, 2020
@x4v13r64 x4v13r64 added enhancement New feature or request release labels Apr 2, 2020
@codecov-io
Copy link
codecov-io commented Apr 2, 2020 •
edited
Loading

Codecov Report

Merging #696 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   66.40%   66.40%           
=======================================
  Files          22       22           
  Lines        1530     1530           
=======================================
  Hits         1016     1016           
  Misses        514      514

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f644fb...2f644fb. Read the comment docs.

@lgtm-com
Copy link
lgtm-com bot commented Apr 2, 2020

This pull request introduces 1 alert when merging ba6b6a6 into fa783ab - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 3, 2020

This pull request introduces 1 alert when merging a1bfda2 into fa783ab - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 3, 2020

This pull request introduces 1 alert when merging 22131e4 into c80d082 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 3, 2020

This pull request introduces 1 alert when merging 1a75ece into c80d082 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 3, 2020

This pull request introduces 1 alert when merging d2446c2 into c80d082 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 3, 2020

This pull request introduces 1 alert when merging 404ac6d into c80d082 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 5, 2020

This pull request introduces 1 alert when merging 683d87a into 607d683 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 6, 2020

This pull request introduces 2 alerts when merging d269d27 into bc0ef14 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Apr 7, 2020

This pull request introduces 2 alerts when merging 1416665 into bc0ef14 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

@lgtm-com
Copy link
lgtm-com bot commented Jun 10, 2020

This pull request introduces 5 alerts and fixes 7 when merging 48f8478 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link
lgtm-com bot commented Jun 10, 2020

This pull request introduces 5 alerts and fixes 7 when merging fb10f70 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link
lgtm-com bot commented Jun 11, 2020

This pull request introduces 5 alerts and fixes 7 when merging 35f9ed2 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

x4v13r64 and others added 2 commits June 15, 2020 09:13
@x4v13r64
Fix bug
3048b25
@x4v13r64
Merge pull request #785 from nccgroup/bugfix/trustedservices
807d2bf 
Improve Trusted Microsoft Services Enabled rule (fixes #763)
@lgtm-com
Copy link
lgtm-com bot commented Jun 15, 2020

This pull request introduces 5 alerts and fixes 7 when merging 807d2bf into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link
lgtm-com bot commented Jun 15, 2020

This pull request introduces 5 alerts and fixes 7 when merging 6f956d3 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link
lgtm-com bot commented Jun 17, 2020

This pull request introduces 5 alerts and fixes 7 when merging e721f70 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@x4v13r64 x4v13r64 mentioned this pull request Jun 18, 2020
Closed
@lgtm-com
Copy link
lgtm-com bot commented Jun 22, 2020

This pull request introduces 5 alerts and fixes 7 when merging 0bf5c3f into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

gebailey and others added 3 commits June 26, 2020 13:28
@gebailey
Don't generate redshift findings for default parameter groups
256577c 
AWS Redshift generates default parameter groups (e.g. "default.redshift-1.0")
that have certain parameters that can generate findings, such as
"enable_user_activity_logging" == "false", and "require_ssl" == "false".

The user is unable to modify these parameters, so in cases where a default
parameter group exists, findings will be generated which the user has no
ability to remediate.

The "redshift-parameter-group-logging-disabled" and
"redshift-parameter-group-ssl-not-required" rules are modified to only apply to
non-default parameter groups for which the user can be expected to remediate.
@x4v13r64
Update rules
f737b07
@x4v13r64
Merge pull request #803 from nccgroup/redshift-skip-default-parameter…
0adacd6 
…-groups

Don't generate redshift findings for default parameter groups
@lgtm-com
Copy link
lgtm-com bot commented Jun 27, 2020

This pull request introduces 5 alerts and fixes 7 when merging 0adacd6 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@x4v13r64
Merge pull request #799 from nccgroup/bugfix/rds
7d1af07 
Fix RDS No Minor Version Upgrade Rule
@lgtm-com
Copy link
lgtm-com bot commented Jun 29, 2020

This pull request introduces 5 alerts and fixes 7 when merging 7d1af07 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link
lgtm-com bot commented Jul 1, 2020

This pull request introduces 5 alerts and fixes 7 when merging 5c21294 into bc0ef14 - view on LGTM.com

new alerts:

  • 4 for Loop variable capture
  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Unused import
  • 1 for Unnecessary pass
  • 1 for Unused local variable

@x4v13r64 x4v13r64 merged commit 8291714 into master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@x4v13r64 @codecov-io @jonathanwcrane @codecov-commenter @ramimac @alessandrogonzalez3 @tkeech1 @JJmako @alessandrogonzalez @gebailey
0