8000 Improve Trusted Microsoft Services Enabled rule (fixes #763) by ramimac · Pull Request #785 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Trusted Microsoft Services Enabled rule (fixes #763) #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Improve Trusted Microsoft Services Enabled rule (fixes #763) #785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8b9b18
fixes #763
ramimac Jun 10, 2020
3048b25
Fix bug
x4v13r64 Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ScoutSuite/providers/azure/resources/storageaccounts/storage_accounts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def _is_public_traffic_allowed(self, storage_account):
return storage_account.network_rule_set.default_action == "Allow"

def _is_trusted_microsoft_services_enabled(self, storage_account):
return storage_account.network_rule_set.bypass == "AzureServices"
if storage_account.network_rule_set.bypass:
return "AzureServices" in storage_account.network_rule_set.bypass
return False

def _parse_access_keys_last_rotation_date(self, activity_logs):
last_rotation_date = None
Expand Down
0