8000 Azure Support Tags and Resource Groups by lowSoA · Pull Request #789 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Azure Support Tags and Resource Groups #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2020
Merged

Azure Support Tags and Resource Groups #789

merged 9 commits into from
Jul 1, 2020

Conversation

lowSoA
Copy link
Contributor
@lowSoA lowSoA commented Jun 12, 2020 •
edited
Loading

Description

  • Add tags processing at resource level and show in HTML report.
  • Add resource group processing and show in HTML report.

Fixes #660

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that 8000 my feature works (optional)
  • New and existing unit tests pass locally with my changes

Viatcheslav Zhilin added 3 commits June 10, 2020 16:42
Added tags for resources:
abc8a5a 
- Virtualmachines: instances
- Storageaccounts: storage_accounts
- SQLDatabase: server
WIP: SQLDatabase database resources
Added tags for resources:
3080dea 
- AAD: serviceprincipals
- Appservice: web_apps
- Keyvault: vaults
- Network: network_interfaces, application_security_groups, security_groups, virtual_networks, watchers
Fixed bug when empty/no tags + resource group name processing and par…
06d282f 
…tial view for:

- Appservice: web_apps
- Keyvault: vaults
- Network: application_security_groups, network_interfaces, security_groups, virtual_networks, watchers
- SQLdatabase: servers, databases
- Storageaccounts: storage_accounts
- Virtualmachines: instances

Useful reference: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-support-resources
@x4v13r64
Copy link
Collaborator
x4v13r64 commented Jun 12, 2020 •
edited
Loading

Mixed commits with #733, will have to merge that PR prior to this one.

@x4v13r64
Copy link
Collaborator

@lowSoA there are a few conflicting files, please merge develop into this branch.

@lowSoA lowSoA added component-provider-azure Affects Azure provider enhancement New feature or request labels Jun 12, 2020
@x4v13r64 x4v13r64 added this to the 5.10 milestone Jun 12, 2020
@lowSoA lowSoA self-assigned this Jun 12, 2020
@codecov-commenter
Copy link
codecov-commenter commented Jun 12, 2020 •
edited
Loading

Codecov Report

Merging #789 into develop will decrease coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #789      +/-   ##
===========================================
- Coverage    66.53%   65.61%   -0.93%     
===========================================
  Files           22       22              
  Lines         1539     1582      +43     
===========================================
+ Hits          1024     1038      +14     
- Misses         515      544      +29
Impacted Files Coverage Δ
ScoutSuite/__main__.py 14.92% <0.00%> (-4.13%) ⬇️
ScoutSuite/core/utils.py 86.36% <0.00%> (+0.31%) ⬆️
ScoutSuite/providers/base/configs/browser.py 62.16% <0.00%> (+8.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b77a2...157b2f8. Read the comment docs.

alessandrogonzalez
alessandrogonzalez reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor
@alessandrogonzalez alessandrogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pending to be merged to 5.10.

As @j4v said, this is mixed with the commits of another PR (#733), so the other one will be merged first.

@alessandrogonzalez alessandrogonzalez linked an issue Jul 1, 2020 that may be closed by this pull request
Azure Support Tags & Resource Groups #660
Closed
4 tasks
@x4v13r64 x4v13r64 changed the base branch from develop to release/5.10 July 1, 2020 16:17
x4v13r64 added 4 commits July 1, 2020 18:22
@x4v13r64
Tweak partial
6da5365
@x4v13r64
Merge branch 'release/5.10' into enhancement/azure-support-tags-res_g…
c854336 
…roups

# Conflicts:
#	ScoutSuite/providers/aws/resources/ec2/ami.py
@x4v13r64
Merge branch 'release/5.10' into enhancement/azure-support-tags-res_g…
26c2c5f 
…roups

# Conflicts:
#	ScoutSuite/output/data/html/partials/aws/services.rds.regions.id.vpcs.id.instances.html
@x4v13r64
Fix partial
dc0ebcc
@x4v13r64 x4v13r64 merged commit 77f7a37 into release/5.10 Jul 1, 2020
@x4v13r64 x4v13r64 deleted the enhancement/azure-support-tags-res_groups branch July 1, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrogonzalez alessandrogonzalez alessandrogonzalez left review comments

Assignees

@lowSoA lowSoA

Labels
component-provider-azure Affects Azure provider enhancement New feature or request
Projects
None yet
Milestone
5.10
Development

Successfully merging this pull request may close these issues.

Azure Support Tags & Resource Groups
4 participants
@lowSoA @x4v13r64 @codecov-commenter @alessandrogonzalez
0