8000 Bugfix/Fix Filters and Callbacks by x4v13r64 · Pull Request #810 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix/Fix Filters and Callbacks #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2020
Merged

Bugfix/Fix Filters and Callbacks #810

merged 5 commits into from
Jul 16, 2020

Conversation

x4v13r64
Copy link
Collaborator
@x4v13r64 x4v13r64 commented Jul 4, 2020 •
edited
Loading

Description

Fixes a few callbacks and addresses #790 & #809.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@x4v13r64 x4v13r64 marked this pull request as draft July 4, 2020 09:51
@x4v13r64 x4v13r64 marked this pull request as ready for review July 4, 2020 09:57
@x4v13r64
Copy link
Collaborator Author
x4v13r64 commented Jul 4, 2020
8000

@alessandrogonzalez & @ramimac this should fix the issues you've raised. Please test and merge.

@x4v13r64 x4v13r64 added this to the 5.10 milestone Jul 4, 2020
@x4v13r64 x4v13r64 added bugfix component-provider-aws Affects AWS provider labels Jul 4, 2020
alessandrogonzalez
alessandrogonzalez reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor
@alessandrogonzalez alessandrogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. Looks good to me.

@x4v13r64 x4v13r64 merged commit 5a8175f into develop Jul 16, 2020
@x4v13r64 x4v13r64 deleted the bugfix/filters-and-callbacks branch July 16, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrogonzalez alessandrogonzalez alessandrogonzalez left review comments

@ramimac ramimac Awaiting requested review from ramimac

Assignees
No one assigned
Labels
bugfix component-provider-aws Affects AWS provider
Projects
None yet
Milestone
5.10
Development

Successfully merging this pull request may close these issues.
2 participants
@x4v13r64 @alessandrogonzalez
0