8000 Bugfix/Improve Error & Exception Handling by x4v13r64 · Pull Request #824 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix/Improve Error & Exception Handling #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 28, 2020
Merged

Bugfix/Improve Error & Exception Handling #824

merged 9 commits into from
Jul 28, 2020

Conversation

x4v13r64
Copy link
Collaborator

Description

This PR is a hotfix for #821, to be released under 5.9.1.

In addition, it improves exception handling for the main _run function, as well as for the Azure provider.

The new error codes can be found under https://github.com/nccgroup/ScoutSuite/wiki/Error-Codes.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@x4v13r64 x4v13r64 changed the title Bugfix/ Bugfix/Exception Handling Jul 28, 2020
@x4v13r64 x4v13r64 changed the title Bugfix/Exception Handling Bugfix/Improve Error & Exception Handling Jul 28, 2020
@x4v13r64 x4v13r64 closed this Jul 28, 2020
@x4v13r64 x4v13r64 reopened this Jul 28, 2020
@x4v13r64
Copy link
Collaborator Author

I've had to add some of the CI improvements from #806.

@x4v13r64 x4v13r64 requested a review from thommor July 28, 2020 13:15
thommor
thommor previously approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor
@thommor thommor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@x4v13r64 x4v13r64 merged commit e5dd01d into master Jul 28, 2020
@x4v13r64 x4v13r64 deleted the bugfix/5.9.1 branch July 28, 2020 14:49
@x4v13r64 x4v13r64 mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thommor thommor thommor left review comments

Assignees
No one assigned
Labels
bugfix component-provider-azure Affects Azure provider release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x4v13r64 @thommor
0