Master to develop #109
Merged
Master to develop #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add main test with mocking relevant objects
|
Taking into account the later, wouldn't it be easier to simply draft a |
|
I think that's a good solution. I'm currently working on a |
AFFD
x4v13r64
approved these changes
Jan 18, 2019
vifor2
approved these changes
Jan 18, 2019
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master is currently ahead of develop. Let's try avoiding this. I suggest setting the default branch to
developinstead ofmaster. This way, new PRs will be againstdevelopby default.One argument against using develop as the default branch is that people looking at the repo will see the develop branch by default.