8000 feature/#30-proprietary by misg · Pull Request #130 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feature/#30-proprietary #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2019
Merged

feature/#30-proprietary #130

merged 2 commits into from
Jan 31, 2019

Conversation

misg
Copy link
Contributor
@misg misg commented Jan 30, 2019

This PR is part of a feature done on the proprietary side. It focusses on parsing blob containers of storage accounts.

@codecov-io
Copy link
codecov-io commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #130 into develop will decrease coverage by 0.06%.
The diff coverage is 18.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
- Coverage    30.17%   30.11%   -0.07%     
===========================================
  Files           63       63              
  Lines         4142     4164      +22     
===========================================
+ Hits          1250     1254       +4     
- Misses        2892     2910      +18
Impacted Files Coverage Δ
...tSuite/providers/azure/services/storageaccounts.py 26.31% <18.18%> (-11.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a516416...b5b0b0c. Read the comment docs.

@misg misg self-assigned this Jan 30, 2019
@misg misg added the component-provider-azure Affects Azure provider label Jan 30, 2019
@misg misg added this to the Milestone 2 milestone Jan 30, 2019
@misg misg added the enhancement New feature or request label Jan 30, 2019
@misg misg requested a review from x4v13r64 January 30, 2019 20:32
@misg misg merged commit 79a0b95 into develop Jan 31, 2019
@misg misg deleted the feature/#30-proprietary branch January 31, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4v13r64 x4v13r64 x4v13r64 approved these changes

@Aboisier Aboisier Aboisier approved these changes

@vifor2 vifor2 Awaiting requested review from vifor2

@Remi05 Remi05 Awaiting requested review from Remi05

@zer0x64 zer0x64 Awaiting requested review from zer0x64

Assignees

@misg misg

Labels
component-provider-azure Affects Azure provider enhancement New feature or request
Projects
None yet
Milestone
Iteration #1
Development

Successfully merging this pull request may close these issues.
4 participants
@misg @codecov-io @x4v13r64 @Aboisier
0