8000 Feature/61 ui improvements by Aboisier · Pull Request #132 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/61 ui improvements #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 31, 2019
Merged

Feature/61 ui improvements #132

merged 16 commits into from
Jan 31, 2019

Conversation

Aboisier
Copy link
Contributor
@Aboisier Aboisier commented Jan 31, 2019 •
edited
Loading

This PR addresses a couple of UI issues (#61). There is still quite a lot do to in my opinion, but this takes care a few irritants.

  1. Navbar refactoring (you can now click outside to close the navbar
  2. The last run data was moved to a modal accessible near the "about section" in the top right corner
  3. Expanding a finding by clicking the + transforms the said + to a -, and vice versa
  4. The services issues page needed a bit more guidance, I refactored it
  5. Added a bit of spacing in the sidebar
  6. Refactored the whole modal system. Clicking outside will now close them. They also have a fancy fade-in animation. There is no code-duplication nightmare anymore.

Sorry about all the file changes. They are mostly one-liners though. It's for a good cause.

demo-ui-improvements

@Aboisier Aboisier added the component-UI Affects UI label Jan 31, 2019
@Aboisier Aboisier added this to the Milestone 2 milestone Jan 31, 2019
@Aboisier Aboisier self-assigned this Jan 31, 2019
@Remi05
Copy link
Contributor
Remi05 commented Jan 31, 2019

Nice work!

@x4v13r64 x4v13r64 mentioned this pull request Jan 31, 2019
Closed
@x4v13r64
Copy link
Collaborator
x4v13r64 commented Jan 31, 2019 •
edited
Loading

gangster

The only thing I'm not super fond of are the badges:

sc_2019-01-31_09h46m01s

As it doesn't convey a "sense of urgency" (I know, I know...).

Maybe we could use some font awesome icons? For example:

Just a thought, otherwise excellent improvements.

@x4v13r64
Copy link
Collaborator

Couple of issues with the dark theme:

The +/- icons are also white, so they aren't very apparent:

sc_2019-01-31_09h37m38s

Under the light theme, it's clear that resources with no instances (Groups) are disabled:

sc_2019-01-31_09h40m36s

Under the dark theme the highlight seems reversed:

sc_2019-01-31_09h40m42s

vifor2
vifor2 approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor
@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new look! 💯

@vifor2
Copy link
Contributor
vifor2 commented Jan 31, 2019

@j4v Duly noted (these changes were caused by my PR last week).

@codecov-io
Copy link
codecov-io commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #132 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #132   +/-   ##
========================================
  Coverage    30.11%   30.11%           
======
8000
==================================
  Files           63       63           
  Lines         4164     4164           
========================================
  Hits          1254     1254           
  Misses        2910     2910

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a0b95...1cd1c2f. Read the comment docs.

@Aboisier Aboisier mentioned this pull request Jan 31, 2019
Closed
@Aboisier
Copy link
Contributor Author

Here are two options to increase the sense of urgency. What do you guys think, @j4v @misg @vifor2 @zer0x64 @Remi05 ?

Option A

image

Option B

image

@x4v13r64
Copy link
Collaborator

Option A

Looks more consistent to me

@Aboisier Aboisier merged commit 6b0e00e into develop Jan 31, 2019
@Aboisier Aboisier deleted the feature/61-ui-improvements branch January 31, 2019 18:45
@Aboisier Aboisier mentioned this pull request Jan 31, 2019
Closed
@Aboisier Aboisier restored the feature/61-ui-improvements branch January 31, 2019 21:50
@misg misg mentioned this pull request Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4v13r64 x4v13r64 x4v13r64 approved these changes

@misg misg misg approved these changes

@Remi05 Remi05 Remi05 approved these changes

@vifor2 vifor2 vifor2 approved these changes

@zer0x64 zer0x64 Awaiting requested review from zer0x64

Assignees

@Aboisier Aboisier

Labels
component-UI Affects UI
Projects
None yet
Milestone
Iteration #1
Development

Successfully merging this pull request may close these issues.
6 participants
@Aboisier @Remi05 @x4v13r64 @vifor2 @codecov-io @misg
0