8000 Update botocore version by alessandrogonzalez · Pull Request #1362 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update botocore version #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

Update botocore version #1362

merged 1 commit into from
Sep 28, 2021

Conversation

alessandrogonzalez
Copy link
Contributor

Description

Updating botocore version since older versions do not include ap-northeast-3 region.

Related: boto/botocore@13447f3

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@alessandrogonzalez alessandrogonzalez added this to the 5.11 milestone Sep 28, 2021
@codecov
Copy link
codecov bot commented Sep 28, 2021

Codecov Report

Merging #1362 (23bed98) into develop (0df06a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1362   +/-   ##
========================================
  Coverage    23.22%   23.22%           
========================================
  Files          334      334           
  Lines        11378    11378           
========================================
  Hits          2642     2642           
  Misses        8736     8736

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df06a9...23bed98. Read the comment docs.

lowSoA
lowSoA approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor
@lowSoA lowSoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessandrogonzalez alessandrogonzalez merged commit 772c43a into develop Sep 28, 2021
@alessandrogonzalez alessandrogonzalez deleted the bugfix/botocore_update_version branch September 28, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowSoA lowSoA lowSoA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.11
Development

Successfully merging this pull request may close these issues.
3 participants
@alessandrogonzalez @lowSoA @alessandrogonzalez3
0