8000 Quoted Python version numbers by ncc-akis · Pull Request #1546 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Quoted Python version numbers #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Quoted Python version numbers #1546

merged 1 commit into from
Jun 30, 2023

Conversation

ncc-akis
Copy link
Contributor

Description

The CI workflow had 3 defined Python version numbers 3.9, 3.10, 3.11. Because these were read as numeric values, 3.10 became 3.1 and broke the workflow because 3.1 wasn't available.

This fixes it by ensuring the version numbers are quoted strings.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@codecov
Copy link
codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (40d699c) 20.53% compared to head (44d9851) 20.53%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1546   +/-   ##
========================================
  Coverage    20.53%   20.53%           
========================================
  Files          384      384           
  Lines        13033    13033           
========================================
  Hits          2676     2676           
  Misses       10357    10357

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fernando-gallego fernando-gallego merged commit 242458a into nccgroup:develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-gallego fernando-gallego fernando-gallego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncc-akis @fernando-gallego
0