8000 Bugfix/lb exceptions by ncc-akis · Pull Request #1548 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix/lb exceptions #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2023
Merged

Bugfix/lb exceptions #1548

merged 3 commits into from
Jun 29, 2023

Conversation

ncc-akis
Copy link
Contributor

Description

Fixes #1532

The HTML templates lacked appropriate <span> elements which permitted the application to generate the appropriate highlighting for finding-related listener port properties.

Adding the <span> elements revealed another issue in the hideAll() function in scoutsuite.js. The CSS selector ensured that all elements with ID containing ".list" were hidden. However, the ID relevant to the current issue contained the string ".listeners" which was also accidentally hidden. I've changed the CSS selectors to use the $= (ends with) rather than *= (contains) operator, and replaced some of the .not() exclusions to match entire strings of "metadata.list" and "filters.list", to prevent further hacks required in the future.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@michyweb michyweb merged commit cb7299d into nccgroup:develop Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncc-akis @michyweb
0