8000 Release fixes by Aboisier · Pull Request #195 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release fixes #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2019
Merged

Release fixes #195

merged 3 commits into from
Feb 20, 2019

Conversation

Aboisier
Copy link
Contributor
@Aboisier Aboisier commented Feb 19, 2019 •
edited
Loading

I had to do three hotfixes because the readme was not showing properly on PyPi. The problem is related to this issue. The post syntax is a bit weird, but it is compliant with PEP 440.

@Aboisier Aboisier self-assigned this Feb 19, 2019
x4v13r64
x4v13r64 previously approved these changes Feb 20, 2019
View reviewed changes
vifor2
vifor2 previously approved these changes Feb 20, 2019
View reviewed changes
@Aboisier Aboisier changed the title Upped the version Release fixes Feb 20, 2019
zer0x64
zer0x64 previously approved these changes Feb 20, 2019
View reviewed changes
@zer0x64
Copy link
Contributor
zer0x64 commented Feb 20, 2019

Tests fails? Time to fix the tests then!

@zer0x64 zer0x64 dismissed stale reviews from vifor2 and themself via 3d992b8 February 20, 2019 14:26
@codecov-io
Copy link

Codecov Report

Merging #195 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #195      +/-   ##
=========================================
+ Coverage   29.48%   29.5%   +0.01%     
=========================================
  Files          69      69              
  Lines        4579    4583       +4     
=========================================
+ Hits         1350    1352       +2     
- Misses       3229    3231       +2
Impacted Files Coverage Δ
ScoutSuite/__init__.py 100% <100%> (ø) ⬆️
ScoutSuite/__main__.py 67.03% <60%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3281859...3d992b8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #195 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #195      +/-   ##
=========================================
+ Coverage   29.48%   29.5%   +0.01%     
=========================================
  Files          69      69              
  Lines        4579    4583       +4     
=========================================
+ Hits         1350    1352       +2     
- Misses       3229    3231       +2
Impacted Files Coverage Δ
ScoutSuite/__init__.py 100% <100%> (ø) ⬆️
ScoutSuite/__main__.py 67.03% <60%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3281859...3d992b8. Read the comment docs.

vifor2
vifor2 approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor
@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I̸̧̘͉̣͙̫̳̝͖̳͕͚̥̺̍̋̿̆͋͢ ̶̴̡̮̭̗̤̖̗͈̖̜͈̰͉͉͂̀͑̈̈͠ͅS̡̱̜̮̩͈̘̱̯̳̳̮͂͊̽ͯ́̒͊͐̏̂̾ͫͧ̎͞͞͝A̖̱̘̳̲͖ͩͭͯ̿ͮ͋͐̅ͭ͘͡I̸̡̖̺͖͓̳̭̭ͮ̿̓̿͡ͅD̨̖̭͖̞̮̝̖̤͚͇̹̣͐̈̉̄́͝͞ ̶̸͙̖̳͙̗͚͉͍̗̜̩̙̜̋̿ͩ̾ͮ̾̍̓͘͠I̡̨͂̅́̒̈́̄̀͂ͥ̒̓̀͐͏̷̻͇̟̜͖̘̕ ̶̨̘̱̥͍̼̄̏͗̍͒̌ͪ̐̍̏ͮ̅ͣ̒̅͊͘͞A̷̛͚̤̦̠͔̖͔͓̰̋̔ͬ̅̀̑͆̑̿̅ͩ̒̌̀̈͝P̴̨̨͚͙̠̮̲̥̺̱̱̮̩͇̻̼͍̣̼̭̽̃̄͗̅̈́̓̿̿͆͡P̵̽̃̾͗́ͮ̄͐͑̐ͧ͌͋ͧͫ͘͢͟͏͇̗͖̜͕̹̗͉̳̟͕͖̼̦̱̫̫̭R̴͙͖̳̥ͮ͋ͪ̑ͯ͗̄̋͂̃ͯ̔̈͂̂͡O̓̍ͭ̌̊ͨͬ͋ͯͨ͆̔ͭ͏̡̖̝̦̱͍͔͓͖̲͓̹̤̗͕͚̭̝̜V̛͉̩̲̪̦͔͖̄̉̎̂̈́ͣ̒ͬ̎͜E̋͌ͧͥͧ̎̽̿͊̒́̉̿͐͂҉̵̤̭̤̜̤̹̠̼̭̤͢͢

@Aboisier Aboisier merged commit 1b4b502 into master Feb 20, 2019
@Aboisier Aboisier deleted the Aboisier-patch-1 branch February 20, 2019 16:03
@x4v13r64
Copy link
Collaborator

@Aboisier any way to make sure in the setup.py that private files aren't added to the package? Would be nice to have a failsafe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifor2 vifor2 vifor2 approved these changes

@zer0x64 zer0x64 zer0x64 approved these changes

@x4v13r64 x4v13r64 x4v13r64 left review comments

@misg misg Awaiting requested review from misg

@Remi05 Remi05 Awaiting requested review from Remi05

Assignees

@Aboisier Aboisier

Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aboisier @zer0x64 @codecov-io @x4v13r64 @vifor2
0