8000 fixed issue with get_value_at by benghaun · Pull Request #318 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixed issue with get_value_at #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

fixed issue with get_value_at #318

merged 1 commit into from
Apr 11, 2019

Conversation

benghaun
Copy link
@benghaun benghaun commented Apr 9, 2019

Fix for #317.

@benghaun benghaun mentioned this pull request Apr 9, 2019
Closed
@codecov-io
Copy link
codecov-io commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #318 into develop will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
+ Coverage    34.61%   34.61%   +<.01%     
===========================================
  Files          176      176              
  Lines         5764     5766       +2     
===========================================
+ Hits          1995     1996       +1     
- Misses        3769     3770       +1
Impacted Files Coverage Δ
ScoutSuite/providers/base/configs/browser.py 50.72% <50%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33841dd...fec5f6d. Read the comment docs.

@Aboisier Aboisier requested a review from x4v13r64 April 9, 2019 13:38
@x4v13r64 x4v13r64 merged commit aacb456 into nccgroup:develop Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4v13r64 x4v13r64 x4v13r64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benghaun @codecov-io @x4v13r64
0