8000 Fixed browser freezing problem by Aboisier · Pull Request #331 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed browser freezing problem #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fixed browser freezing problem #331

merged 1 commit into from
Apr 10, 2019
+2 −2

Conversation

Aboisier
Copy link
Contributor

This PR fixes the bug which caused the browser to freeze when clicking on the EFS findings. The problem was caused by a bad condition. We checked if the element selected with jquery was defined, but jquery doesn't return undefined. We have to check if the length is > 0 instead.

@Aboisier Aboisier added the bug Something isn't working label Apr 10, 2019
@Aboisier Aboisier added this to the Iteration #6 milestone Apr 10, 2019
@Aboisier Aboisier self-assigned this Apr 10, 2019
@Aboisier Aboisier changed the title Fixed bad condition Fixed browser freezing problem Apr 10, 2019
vifor2
vifor2 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor
@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Aboisier Aboisier merged commit 90e6a5c into develop Apr 10, 2019
@Aboisier Aboisier deleted the bugfix/hidden-navbar-items branch April 10, 2019 15:01
@Aboisier Aboisier mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4v13r64 x4v13r64 x4v13r64 approved these changes

@vifor2 vifor2 vifor2 approved these changes

@misg misg Awaiting requested review from misg

@Remi05 Remi05 Awaiting requested review from Remi05

@zer0x64 zer0x64 Awaiting requested review from zer0x64

Assignees

@Aboisier Aboisier

Labels
bug Something isn't working
Projects
None yet
Milestone
Iteration #6
Development

Successfully merging this pull request may close these issues.
3 participants
@Aboisier @x4v13r64 @vifor2
0