Enhancement/NCC corporate theme #389
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #389 +/- ##
===========================================
+ Coverage 34.42% 34.43% +<.01%
===========================================
Files 192 192
Lines 6338 6337 -1
===========================================
Hits 2182 2182
+ Misses 4156 4155 -1
Continue to review full report at Codecov.
|
|
Thanks for this @OliverSmelik, a few comments. Text is off on finding dashboard: Also I get that red is the corporate colour but it's a bit aggressive - any way we can at least make the text highlights softer (maybe bold instead of make red?)? |
|
Sorry about that, the way I have to work causes a bit of confusion sometimes but sorted now. The nav styling wasn't added to the light theme only the dark. Added to both now and pushed. All your styling suggestions have been added, good suggestion on the navigation. I was in two minds with what to go with. I've also made the text increase in size slightly to stand out more. |
I know, I know 😄 Sorry for being picky, a few more comments. "Normal" font for the Scout Suite link is smaller in the Dashboard (although bold): And larger in other pages: Not crazy about the red colour on links: Particularly hard in dark mode: Also the "Danger" highlight (the |
| } | ||
|
|
||
| #account_id .fa-cloud { | ||
| color: orange; |
There was a problem hiding this comment.
Better keep that white, orange would hint to AWS and look a bit weird for GCP/Azure.
|
@j4v No problem, they're good suggestions as I'm just trying to feel out the NCC group 'Style' so a bit of trial and error with the design. I've made those changes and also added a scroll to the filters dropdown in the main navigation as it went off the page for me. |
|
Good stuff @OliverSmelik! Is this expected: Looks a bit off, especially in dark mode. Other then that everything else is 💯 |
|
I've just sent you an email @j4v but I though I should comment on here. I've just had a look at my local copy but it doesn't seem to be the same as your screenshot shows. Here's what mine currently looks like. Note: I don't have the same policy as you either scroll bar design has been applied and should look something like this if it's every applied This is from my latest local copy which has been pushed. Not sure why it's causing your design to look different |
Style Changes to service management/reporting for Scout Suite (not including dark mode yet)