Tags: nealp-meta/dns
Tags
Update blazesym submodule (facebook#99) Summary: Update the blazesym submodule to a version compatible with commit 6324285 ("Update `blazesym` snapshot"). blazesym-c is now stable, so we may be able to go one step further and drop the submodule entirely and rely on distribution package (I don't have all the background why it exists), but I'll leave that for others to decide. - [x] Added tests, if you've added code that should be tested - [x] Updated the documentation, if you've changed APIs - [x] Ensured the test suite passes - [x] Made sure your code lints - [x] Completed the Contributor License Agreement ("CLA") Pull Request resolved: facebook#99 Reviewed By: abulimov Differential Revision: D74242242 Pulled By: deathowl fbshipit-source-id: a3a89347a1b12271224c5f27c242814bfe8f1581
Update golang.org/x/net and migrate golangci-lint 2 (facebook#98) Summary: * update from vulnerable version of golang.org/x/net * Update to golangci-lint 2.x * Address lint issues * Address issues when more than 1 push was made to main failing dnswatch release - [ ] Added tests, if you've added code that should be tested N/A - [ ] Updated the documentation, if you've changed APIs N/A - [x] Ensured the test suite passes - [x] Made sure your code lints - [x] Completed the Contributor License Agreement ("CLA") Pull Request resolved: facebook#98 Reviewed By: abulimov Differential Revision: D73502725 Pulled By: deathowl fbshipit-source-id: b52880633797c1bbf2fde882e33259d203caa3a8
Bump golang.org/x/net from 0.37.0 to 0.38.0 in /dnsrocks (facebook#97) Summary: Bumps [golang.org/x/net](https://github.com/golang/net) from 0.37.0 to 0.38.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9"><code>e1fcd82</code></a> html: properly handle trailing solidus in unquoted attribute value in foreign...</li> <li><a href="https://github.com/golang/net/commit/ebed060e8f30f20235f74808c22125fd86b15edd"><code>ebed060</code></a> internal/http3: fix build of tests with GOEXPERIMENT=nosynctest</li> <li><a href="https://github.com/golang/net/commit/1f1fa29e0a46fffe18c43a9da8daa5a0b180dfa9"><code>1f1fa29</code></a> publicsuffix: regenerate table</li> <li><a href="https://github.com/golang/net/commit/12150816f701c912a32a376754ab28dd3878833a"><code>1215081</code></a> http2: improve error when server sends HTTP/1</li> <li><a href="https://github.com/golang/net/commit/312450e473eae9f9e6173ad895c80bc5ea2f79ad"><code>312450e</code></a> html: ensure <search> tag closes <p> and update tests</li> <li><a href="https://github.com/golang/net/commit/09731f9bf919b00b344c763894cd1920b3d96d90"><code>09731f9</code></a> http2: improve handling of lost PING in Server</li> <li><a href="https://github.com/golang/net/commit/55989e24b972a90ab99308fdc7ea1fb58a96fef1"><code>55989e2</code></a> http2/h2c: use ResponseController for hijacking connections</li> <li><a href="https://github.com/golang/net/commit/2914f46773171f4fa13e276df1135bafef677801"><code>2914f46</code></a> websocket: re-recommend gorilla/websocket</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.37.0...v0.38.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/dns/network/alerts). </details> Pull Request resolved: facebook#97 Reviewed By: t3lurid3 Differential Revision: D73191453 Pulled By: deathowl fbshipit-source-id: ef5a89918851f4f298472f7502552590102dcb5a
Fix lint (facebook#94) Summary: Pull Request resolved: facebook#94 Lint error broke CI: ``` Run golangci/golangci-lint-action@v3: dnsrocks/dnsdata/rearranger.go#L164 S1009: should omit nil check; len() for nil slices is defined as zero (gosimple) ``` Reviewed By: mjdiffy Differential Revision: D71162315 fbshipit-source-id: 240babc6754b265dc778d72b3ae88ed0a1debdc1
Add response time field Summary: Adding response time to requests logged using Scribe. It will allow us to do analysis and find interesting insights for our server such as what queries are taking the most time, how much time specific domains take, etc. I'm also removing the calls to `LogFailed` in the `chaseCNAME` method because 1) it leads to duplicate logs since its being called once in there and then it gets called later in `ServeDNSWithRCODE`, 2) its purpose is for internal failure logging whereas `dns_logs` is used to log client requests, 3) We log those failures to `glog` so if we need debugging info, it can be accessed through there. Logarithm can be used to increase the retention policy; I'm not sure if that's enabled or not, but its not a high priority right now. Reviewed By: mjdiffy Differential Revision: D71021104 fbshipit-source-id: cf8a2aa05f32599ecfe451ffde91d66062085b75
update glog to v1.2.4 (facebook#91) Summary: Pull Request resolved: facebook#91 Reviewed By: abulimov Differential Revision: D68790324 Pulled By: pmazzini fbshipit-source-id: 82faaea6d2f09387776a82e0e6161d778fc4d091
expose set_disable_auto_compactions option Summary: We need this downstream in one of our service. Reviewed By: abulimov Differential Revision: D67906445 fbshipit-source-id: 74f3aa0085b97fe29ddc136337cf80a3f36b6730
update golang.org/x/net to 0.33 (facebook#89) Summary: dependabot flagged it as vulnerable. Pull Request resolved: facebook#89 Reviewed By: abulimov Differential Revision: D67447206 Pulled By: deathowl fbshipit-source-id: 1664e4a08aa707e5b4a9d3cf22222bf5eed45100
Update golang.org/x/crypto package (facebook#88) Summary: **What:** Update `dnsrocks/go.mod` **Why:** golang.org/x/crypto being updated to 0.31.0 due to security vulnerability in versions <0.31.0 **How:** Update `go.mod` and run `go mod tidy` **Risks:** Low risk **Checklist**: - [ ] Added tests, if you've added code that should be tested N/A - [ ] Updated the documentation, if you've changed APIs N/A - [x] Ensured the test suite passes - [x] Made sure your code lints - [ ] Completed the Contributor License Agreement ("CLA") N/A Pull Request resolved: facebook#88 Reviewed By: deathowl Differential Revision: D67287348 Pulled By: t3lurid3 fbshipit-source-id: 94f22e50b8b520f9af16541a5f198ae877211c1a
fix build + make build static + create release on github (facebook#86) Summary: **What:** Making dnswatch build great again **Why:** Broken builds are sad **How:** Makefile magic 🎩 **Risks:** **Checklist**: <!-- Have you done all of these things? To check an item, place an "x" in the box like so: "- [x] Tests" Add "N/A" to the end of each line that's irrelevant to your changes --> - [ ] Added tests, if you've added code that should be tested - [ ] Updated the documentation, if you've changed APIs - [x] Ensured the test suite passes - [x] Made sure your code lints - [x] Completed the Contributor License Agreement ("CLA") Pull Request resolved: facebook#86 Reviewed By: leoleovich Differential Revision: D66815782 Pulled By: deathowl fbshipit-source-id: da69cbdb7a4eee8413f87d20100e59fb32f1ab74