feat: stabilize account_id_in_function_call_permission protocol feature #7569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53e7c04 to
925392a
Compare
925392a to
7707ef8
Compare
mm-near
approved these changes
Sep 7, 2022
|
@akhi3030 could you also take a look here? I think we require two approvals for stabilization? |
|
Took me some time to figure out where we are setting My only other question is do we know if this impacts any existing workflows? If this breaks some existing workflow, do we have a plan on how to address that? |
|
I don't think this would impact existing valid workflows:
|
akhi3030
approved these changes
Sep 7, 2022
nikurt
pushed a commit
that referenced
this pull request
Sep 7, 2022
…re (#7569) # account_id_in_function_call_permission This feature controls [the check](https://github.com/near/nearcore/blob/b315192e84d388671316deaa3a17ece9d0565fd1/runtime/runtime/src/verifier.rs#L400-L405) which enforces that account id in function call permission is indeed a valid account id. Before, any string could have been used there. The primary motivation is robustness -- by restricting permissions to only valid account ids, we don't have to deal with potentially arbitrary long strings in storage. # Context - Implementation: #7139 # Testing and QA We have basic and upgradability test [here](https://github.com/near/nearcore/blob/master/integration-tests/src/tests/client/features/account_id_in_function_call_permission.rs#L18). This PR also adds a test for an extra edge case with overly long account id. This feature have been running on betanet for couple of months without problems. # Checklist - [x] Link to nightly nayduck run: https://nayduck.near.org/#/run/2667 - [x] Update CHANGELOG.md to include this protocol feature in the `Unreleased` section.
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
…re (#7569) # account_id_in_function_call_permission This feature controls [the check](https://github.com/near/nearcore/blob/b315192e84d388671316deaa3a17ece9d0565fd1/runtime/runtime/src/verifier.rs#L400-L405) which enforces that account id in function call permission is indeed a valid account id. Before, any string could have been used there. The primary motivation is robustness -- by restricting permissions to only valid account ids, we don't have to deal with potentially arbitrary long strings in storage. # Context - Implementation: #7139 # Testing and QA We have basic and upgradability test [here](https://github.com/near/nearcore/blob/master/integration-tests/src/tests/client/features/account_id_in_function_call_permission.rs#L18). This PR also adds a test for an extra edge case with overly long account id. This feature have been running on betanet for couple of months without problems. # Checklist - [x] Link to nightly nayduck run: https://nayduck.near.org/#/run/2667 - [x] Update CHANGELOG.md to include this protocol feature in the `Unreleased` section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per li
2E1A
ne can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
account_id_in_function_call_permission
This feature controls the check which enforces that account id in function call permission is indeed a valid account id. Before, any string could have been used there. The primary motivation is robustness -- by restricting permissions to only valid account ids, we don't have to deal with potentially arbitrary long strings in storage.
Context
Testing and QA
We have basic and upgradability test here. This PR also adds a test for an extra edge case with overly long account id. This feature have been running on betanet for couple of months without problems.
Checklist
Unreleasedsection.