8000 moved Network(View)Client(Messages/Responses) to near_client by pompon0 · Pull Request #7908 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

moved Network(View)Client(Messages/Responses) to near_client #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 25, 2022
Merged

moved Network(View)Client(Messages/Responses) to near_client #7908

merged 11 commits into from
Oct 25, 2022

Conversation

pompon0
Copy link
Contributor
@pompon0 pompon0 commented Oct 24, 2022 •
edited
Loading

These actix messages are an implementation detail of near_client crate.

@pompon0 pompon0 requested a review from matklad October 24, 2022 10:30
@pompon0 pompon0 requested a review from a team as a code owner October 24, 2022 10:30
matklad
matklad reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor
@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened with ReasonForBan?

Not to imply that anything is wrong with it, just that it looks like something's changedwith our strategy of handling that, and it's a bit hard to understand what that was exactly from current PR description and diff )

@pompon0
Copy link
Contributor Author
pompon0 commented Oct 24, 2022

ReasonForBan is returned only from a handful of handlers. I didn't know that until I implemented #7895 . Interface in this PR is the final one. The next PR just reimplements Adapter.

@pompon0 pompon0 requested a review from matklad October 24, 2022 11:54
matklad
matklad reviewed Oct 24, 2022
View reviewed changes
@pompon0 pompon0 changed the title replaced Client struct with async_trait moved Network(View)Client(Messages/Responses) to near_client Oct 24, 2022
@pompon0 pompon0 requested a review from matklad October 24, 2022 15:34
@near-bulldozer near-bulldozer bot merged commit 407d283 into master Oct 25, 2022
@near-bulldozer near-bulldozer bot deleted the gprusak-async-trait branch October 25, 2022 12:01
nikurt pushed a commit that referenced this pull request Oct 25, 2022
@pompon0
moved Network(View)Client(Messages/Responses) to near_client (#7908)
a77b73d 
These actix messages are an implementation detail of near_client crate.
nikurt pushed a commit that referenced this pull request Nov 7, 2022
@pompon0
moved Network(View)Client(Messages/Responses) to near_client (#7908)
390f52b 
These actix messages are an implementation detail of near_client crate.
nikurt pushed a commit that referenced this pull request Nov 9, 2022
@pompon0
moved Network(View)Client(Messages/Responses) to near_client (#7908)
6b9fc53 
These actix messages are an implementation detail of near_client crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pompon0 @matklad
0