8000 Migrate boot node and blacklisting tests to network crate by saketh-are · Pull Request #8109 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate boot node and blacklisting tests to network crate #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 28, 2022
Merged

Migrate boot node and blacklisting tests to network crate #8109

merged 12 commits into from
Nov 28, 2022

Conversation

saketh-are
Copy link
Collaborator
@saketh-are saketh-are commented Nov 23, 2022 •
edited
Loading

These tests verify the behavior for connections formed after starting a network with boot nodes, as well as boot nodes with blacklisted peers.

This PR migrates them from integration-tests into the chain/network crate. The goals for this migration are to:

  • utilize the internal APIs of the near-network crate
  • make the tests await the changes rather than poll
  • to decrease the public API surface of the near-network crate

@saketh-are saketh-are marked this pull request as ready for review November 23, 2022 21:46
@saketh-are saketh-are requested a review from a team as a code owner November 23, 2022 21:46
@saketh-are saketh-are requested a review from mm-near November 23, 2022 21:46
@pompon0 pompon0 requested review from pompon0 and removed request for mm-near November 24, 2022 10:31
pompon0
pompon0 reviewed Nov 24, 2022
View reviewed changes
pompon0
pompon0 suggested changes Nov 24, 2022
View reviewed changes
Copy link
Contributor
@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at the inline comments

@pompon0 pompon0 self-requested a review November 25, 2022 10:16
@saketh-are
Copy link
Collaborator Author

PTAL at the inline comments

Addressed, PTAL

pompon0
pompon0 reviewed Nov 28, 2022
View reviewed changes
@saketh-are saketh-are requested a review from pompon0 November 28, 2022 14:18
@near-bulldozer near-bulldozer bot merged commit f9950fd into near:master Nov 28, 2022
@saketh-are saketh-are mentioned this pull request Dec 6, 2022
Merged
near-bulldozer bot pushed a commit that referenced this pull request Dec 7, 2022
@saketh-are
Migrate remaining routing tests to network crate (#8168)
a0def6d 
Follow up to #8073, #8109, and #8110 for the two remaining tests in `integration-tests/src/tests/network/routing.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saketh-are @pompon0
0