fix(integration-tests): fix tests after tx status RPC changes #8289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
near#7928 changed `Chain::get_recursive_transaction_results()` to skip refund receipts, so the several checks for receipts outcome length in `standard_cases::rpc` are now wrong, because they expect to find the refunds. Fix it by changing all these asserts failed tests (the ones that start with `standard_cases::rpc::`): https://nayduck.near.org/#/run/2802 to be safe, can check that these are indeed refunds by printing rceipts out like: ``` for r in transaction_result.receipts_outcome.iter() { let b = node_user.get_block(r.block_hash).unwrap(); let mut found = false; 'outer: for c in b.chunks { let ch = node_user.get_chunk_by_height(b.header.height, c.shard_id).unwrap(); for receipt in ch.receipts { if receipt.receipt_id == r.id { dbg!(receipt); found = true; break 'outer; } } } if !found { eprintln!("wtf cant find {}", r.id); } } ```
Chain::get_final_transaction_result
nikurt
approved these changes
Jan 5, 2023
anthony-near
added a commit
that referenced
this pull request
Jan 18, 2023
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7928 changed
Chain::get_recursive_transaction_results()to skip refund receipts, so the several checks for receipts outcome length instandard_cases::rpcare now wrong, because they expect to find the refunds. Fix it by changing all these asserts, and by changingRuntimeUser::get_recursive_transaction_resultsto matchChain::get_recursive_transaction_resultsfailed tests (the ones that start with
standard_cases::rpc::): https://nayduck.near.org/#/run/2802to be safe, can check that these are indeed refunds by printing rceipts out like: