fixed broadcasting AccountData after node restart. #8407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-near
reviewed
Jan 23, 2023
mm-near
reviewed
Jan 23, 2023
mm-near
reviewed
Jan 23, 2023
| if !self.is_n 10000 ew(&d) { | ||
| return None; | ||
| } | ||
| let d = match &self.local { | ||
| Some(local) if d.account_key == local.signer.public_key() => Arc::new( | ||
| VersionedAccountData { |
There was a problem hiding this comment.
shouldn't we do it only if account data differs?
There was a problem hiding this comment.
we could, but we don't care. If we encounter anything that we don't know that we have signed, we override it. It is a form of defense in depth - especially since the underlying proto may contain extra information that we cannot interpret (the received data might have been signed by a different neard version).
mm-near
reviewed
Jan 23, 2023
mm-near
reviewed
Jan 23, 2023
mm-near
approved these changes
Jan 25, 2023
near-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
This is a roll forward of #8182 , which was reverted by #8314 . The issue that #8182 caused has been fixed in #8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
AccountData is broadcasted by validator node periodically (every 15min). AccountData with greatest `version` field is considered the freshest. We do not store the latest broadcasted version in storage, so each time node is restarted, is starts with version = 1, unless it learns the latest broadcasted version (from the previous execution) from the network. It means that it may happen that the correct AccountData will be broadcasted only after 15min from restart. This in turn means that the validator might be not reachable (messages cannot be routed to it) for 15min which is unacceptable. We fix that by making the validator node broadcast a new version of AccountData as soon as it learns about stale AccountData (but with higher version) from the network. Alternative solutions considered are described in the accounts_data/mod.rs (see documentation of is_new() function).
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, 8000 compared to master.
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
AccountData is broadcasted by validator node periodically (every 15min). AccountData with greatest `version` field is considered the freshest. We do not store the latest broadcasted version in storage, so each time node is restarted, is starts with version = 1, unless it learns the latest broadcasted version (from the previous execution) from the network. It means that it may happen that the correct AccountData will be broadcasted only after 15min from restart. This in turn means that the validator might be not reachable (messages cannot be routed to it) for 15min which is unacceptable. We fix that by making the validator node broadcast a new version of AccountData as soon as it learns about stale AccountData (but with higher version) from the network. Alternative solutions considered are described in the accounts_data/mod.rs (see documentation of is_new() function).
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
ppca
pushed a commit
to ppca/nearcore
that referenced
this pull request
Jan 30, 2023
AccountData is broadcasted by validator node periodically (every 15min). AccountData with greatest `version` field is considered the freshest. We do not store the latest broadcasted version in storage, so each time node is restarted, is starts with version = 1, unless it learns the latest broadcasted version (from the previous execution) from the network. It means that it may happen that the correct AccountData will be broadcasted only after 15min from restart. This in turn means that the validator might be not reachable (messages cannot be routed to it) for 15min which is unacceptable. We fix that by making the validator node broadcast a new version of AccountData as soon as it learns about stale AccountData (but with higher version) from the network. Alternative solutions considered are described in the accounts_data/mod.rs (see documentation of is_new() function).
ppca
pushed a commit
to ppca/nearcore
that referenced
this pull request
Jan 30, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountData is broadcasted by validator node periodically (every 15min).
AccountData with greatest
versionfield is considered the freshest.We do not store the latest broadcasted version in storage, so each time node is restarted, is starts with version = 1, unless it learns the latest broadcasted version (from the previous execution) from the network.
It means that it may happen that the correct AccountData will be broadcasted only after 15min from restart.
This in turn means that the validator might be not reachable (messages cannot be routed to it) for 15min which is unacceptable. We fix that by making the validator node broadcast a new version of AccountData as soon as it learns about stale AccountData (but with higher version) from the network.
Alternative solutions considered are described in the accounts_data/mod.rs (see documentation of is_new() function).