8000 fix: bump protocol version for ed25519 verify by jakmeier · Pull Request #8446 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: bump protocol version for ed25519 verify #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 10, 2023
Merged

fix: bump protocol version for ed25519 verify #8446

merged 13 commits into from
Feb 10, 2023

Conversation

jakmeier
Copy link
Contributor

The protocol bump to 58 will be backported to release 1.31, the
new feature to verify ed25519 through a host function therefore needs
to be pushed to version 59.

@jakmeier
fix: bump protocol version for ed25519 verify
cceb315 
The protocol bump to 58 will be backported to a previous release, the
new feature to verify ed25519 through a host function therefore needs
to be pushed to version 59.
@jakmeier jakmeier requested a review from a team as a code owner January 26, 2023 09:14
@jakmeier
Copy link
Contributor Author

I got a bit confused around the bump in #8360 and approved #8098 to be merged without a bump because I thought we already had one for the next release. But if I understand this right now, we need to put new features to version 59.

@jakmeier
Copy link
Contributor Author

This is currently blocked on

[2023-01-26 09:18:16] INFO: Got protocol 57 in mainnet release 1.30.0.
[2023-01-26 09:18:16] INFO: Got protocol 57 in testnet release 1.30.0-rc.6.
[2023-01-26 09:18:16] INFO: Got protocol 59 on master branch.
Traceback (most recent call last):
  File "tests/sanity/upgradable.py", line 194, in <module>
   main()
  File "tests/sanity/upgradable.py", line 189, in main
    test_protocol_versions()
  File "tests/sanity/upgradable.py", line 66, in test_protocol_versions
    assert ok, ('If changed, protocol version of a new release can increase by '
AssertionError: If changed, protocol version of a new release can increase by at most one.
🚨 Error: The command exited with status 1

Will need to come back once the testnet release with the bump is out.

@marcelo-gonzalez
Copy link
Contributor
marcelo-gonzalez commented Jan 26, 2023 •
edited
Loading

This is currently blocked on

[2023-01-26 09:18:16] INFO: Got protocol 57 in mainnet release 1.30.0.
[2023-01-26 09:18:16] INFO: Got protocol 57 in testnet release 1.30.0-rc.6.
[2023-01-26 09:18:16] INFO: Got protocol 59 on master branch.
Traceback (most recent call last):
  File "tests/sanity/upgradable.py", line 194, in <module>
   main()
  File "tests/sanity/upgradable.py", line 189, in main
    test_protocol_versions()
  File "tests/sanity/upgradable.py", line 66, in test_protocol_versions
    assert ok, ('If changed, protocol version of a new release can increase by '
AssertionError: If changed, protocol version of a new release can increase by at most one.
🚨 Error: The command exited with status 1

Will need to come back once the testnet release with the bump is out.

Ah I had only prepared the new 1.31 branch on my fork but hadn't published it to nearcore yet. Although hmm https://s3-us-west-1.amazonaws.com/build.nearprotocol.com/nearcore-deploy/testnet/latest_deploy is still pointing to 1.30.0-rc.6 even though 1.31.0-rc.2 has already been published

@jakmeier
Copy link
Contributor Author
jakmeier commented Feb 6, 2023

@nikurt hasn't 1.31.0-rc.3 with protocol version 58 been released on testnet? Somehow I am still seeing this error:

[2023-02-06 13:06:51] INFO: Got protocol 57 in mainnet release 1.30.0.
[2023-02-06 13:06:51] INFO: Got protocol 57 in testnet release 1.30.0-rc.6.
[2023-02-06 13:06:51] INFO: Got protocol 59 on master branch.
Traceback (most recent call last):
  File "tests/sanity/upgradable.py", line 194, in <module>
   main()
  File "tests/sanity/upgradable.py", line 189, in main
    test_protocol_versions()
  File "tests/sanity/upgradable.py", line 66, in test_protocol_versions
    assert ok, ('If changed, protocol version of a new release can increase by '
AssertionError: If changed, protocol version of a new release can increase by at most one.
🚨 Error: The command exited with status 1

https://buildkite.com/nearprotocol/nearcore/builds/24721#018626d3-0b87-4e75-adb8-6d4625a7ec22/95-680

@nikurt
Copy link
Contributor
nikurt commented Feb 6, 2023

Yes, protocol version 58 was released:

% curl https://rpc.testnet.near.org/status -s | jq -r '[.version.build , .protocol_version]'
[
  "1.31.0-rc.4",
  58
]

@jakmeier
Copy link
Contributor Author
jakmeier commented Feb 6, 2023 •
edited
Loading

@nikurt Ok I see, then it was released but somehow upgradable.py does not know it. The test looks at https://s3-us-west-1.amazonaws.com/build.nearprotocol.com/testnet/latest_deploy to figure out what the latest release on testnet is and that still returns Got protocol 57 in testnet release 1.30.0-rc.6.. Both on buildkite and when I rerun locally.

Do you know how to update that?

@nikurt
Copy link
Contributor
nikurt commented Feb 6, 2023

Do you know how to update that?

Reached out to @anshal-savla about that.

@near-bulldozer near-bulldozer bot merged commit 910e94b into near:master Feb 10, 2023
@jakmeier jakmeier deleted the bump-59 branch February 10, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

@marcelo-gonzalez marcelo-gonzalez marcelo-gonzalez approved these changes

@mzhangmzz mzhangmzz Awaiting requested review from mzhangmzz mzhangmzz is a code owner automatically assigned from near/nearcore-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakmeier @marcelo-gonzalez @nikurt @pompon0
0