fix(state-parts): Instrument creation of state parts #9148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the number of nodes at various stages and durations of various stages
Longarithm
reviewed
Jun 6, 2023
core/store/src/metrics.rs
Outdated
| @@ -236,6 +237,91 @@ pub static COLD_COPY_DURATION: Lazy<Histogram> = Lazy::new(|| { | |||
| .unwrap() | |||
| }); | |||
|
|
|||
| pub(crate) static GET_STATE_PART_WITH_FS_ELAPSED: Lazy<Histogram> = Lazy::new(|| { | |||
There was a problem hiding this comment.
Two comments:
- does histogram allow to track the sum of all captured times? I think it is more useful for identifying bottlenecks.
- we need a label
shard_idfor all these metrics
There was a problem hiding this comment.
Yes, histograms export:
- Count per bucket
- Sum of all values
- Count of all values
Added shard_id to all metrics.
* stabilize finite-wasm and near-vm * fix tests that were not prepared by nightly integration
Longarithm
approved these changes
Jun 6, 2023
wacban
reviewed
Jun 6, 2023
core/store/src/trie/state_parts.rs
Outdated
Comment on lines
97
to
98
| let trie_values = if self.is_flat_storage_head_at(prev_hash) { | ||
| self.get_trie_nodes_for_part_with_flat_storage(part_id)? | ||
| self.get_trie_nodes_for_part_with_flat_storage(part_id, shard_id)? |
There was a problem hiding this comment.
Sanity check - is there any potential for a race condition here?
There was a problem hiding this comment.
Maaaaybe, but #9090 will make it impossible. This will use static DB snapshots.
As the test requires some dependencies like `base58` and `retrying` which are not available by default.
Mainly adding some type annotations across the code to make pyright type checker happy. To use the type checker, you'll need to install it [1] and run "pyright file.py" to show the warnings. [1] https://github.com/microsoft/pyright
|
I pushed a commit to the branch of the fork, but I don't see the diff updated in this
8000
PR 🤔 |
nikurt
added a commit
that referenced
this pull request
Jun 9, 2023
Metrics for creation of state parts: * Durations of various stages * Numbers of nodes created during various stages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggesti
30B9
on is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics for creation of state parts: