8000 Delete tier1_network_info RPC endpoint by saketh-are · Pull Request #9403 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Delete tier1_network_info RPC endpoint #9403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2023
Merged

Delete tier1_network_info RPC endpoint #9403

merged 2 commits into from
Aug 9, 2023

Conversation

saketh-are
Copy link
Collaborator

This endpoint was added mistakenly (by me) in #8181.

It returns a response completely identical to the one given by the network_info endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and tier1_network_info was used 0 times.

@saketh-are saketh-are requested a review from telezhnaya August 9, 2023 18:20
@saketh-are saketh-are requested a review from a team as a code owner August 9, 2023 18:20
@saketh-are saketh-are requested a review from Longarithm August 9, 2023 18:20
telezhnaya
telezhnaya approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor
@telezhnaya telezhnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, though we need to think about whether we are OK with the theoretical lack of backward compatibility

I've collected the stats from Prometheus, yeap, it was never used

@near-bulldozer near-bulldozer bot merged commit 988039b into near:master Aug 9, 2023 8000
nikurt pushed a commit that referenced this pull request Aug 24, 2023
@saketh-are
Delete tier1_network_info RPC endpoint (#9403)
102eb4c 
This endpoint was added mistakenly (by me) in #8181.

It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
telezhnaya added a commit to telezhnaya/nearcore that referenced this pull request Aug 25, 2023
@telezhnaya
drop EXPERIMENTAL_changes_in_block RPC endpoint, cleanup
a79f767 
Drop EXPERIMENTAL_changes_in_block RPC endpoint
Drop leftovers after near#9403
@telezhnaya telezhnaya mentioned this pull request Aug 25, 2023
Closed
nikurt pushed a commit that referenced this pull request Aug 28, 2023
@saketh-are
Delete tier1_network_info RPC endpoint (#9403)
793eb97 
This endpoint was added mistakenly (by me) in #8181.

It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telezhnaya telezhnaya telezhnaya approved these changes

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@Longarithm Longarithm Awaiting requested review from Longarithm Longarithm is a code owner automatically assigned from near/nearcore-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saketh-are @telezhnaya @bowenwang1996
0