fix(state-sync): Config option to provide a GCS credentials file in the config file #9487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig.json Also adjust verbosity of state-parts
wacban
approved these changes
Sep 5, 2023
nearcore/src/config.rs
Outdated
Comment on lines
353
to
356
| /// If a node needs to upload state parts to S3. | ||
| pub s3_credentials_file: Option<String>, | ||
| /// If a node needs to upload state parts to GCS. | ||
| pub gcs_credentials_file: Option<String>, |
There was a problem hiding this comment.
8000
nit1: It feels like those should be exclusive. How about putting them in an enum or a runtime check?
nit2: You can also check if the credentials for state_sync.dump.location are Some.
nit3: How about moving those to the state sync config? Please disregard if used elsewhere.
There was a problem hiding this comment.
nit1: Not really. I can imagine a node that has permissions to write to both locations. Anyway, moved the field to DumpConfig, and now it's exclusive.
nit2: Not sure what you meant.
nit3: Moved it to state_sync.dump.credentials_file.
There was a problem hiding this comment.
nit1: ok
nit2:
if location == gcp && gcs_credentials_file.is_none() { return error("missing credentials"); }
// not a biggie
nit3: thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjust verbosity of
state-partslogging