remove force_* features and move runtime selection to runtime configuration #9539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This ought to be a non functional change… |
767331c to
9cbd9fb
Compare
jakmeier
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
I like this change!
I left many comments but most of them are for the same question: Why are we testing protocol version !0 rather than PROTOCOL_VERSION? I think when running tests without the nightly feature, we don't want the nightly version runtime configs to apply, right?
integration-tests/src/tests/client/features/increase_deployment_cost.rs
Outdated
Show resolved
Hide resolved
ef2c776 to
497baf7
Compare
…ration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a differ 8000 ent runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay!
3c5bb2d to
a7c9ad1
Compare
nikurt
pushed a commit
that referenced
this pull request
Sep 22, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime con 8000 figuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this pull request
Oct 2, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this pull request
Oct 2, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of reasons, but the most major one is that these
force_*fetures make it impossible to run tools with--all-featuresenabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.)That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.)
As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence
Fixes #8202
and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay!