Logging: Deprecate --verbose
#9547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--verbose is not a bool, but a String argument, which is confusing.
--verbose is not a bool, but a String argument, which is confusing.
2 tasks
mina86
reviewed
Sep 21, 2023
neard/src/cli.rs
Outdated
Comment on lines
180
to
190
| match self.verbose { | ||
| None => None, | ||
| Some(None) => Some(""), | ||
| Some(Some(ref target)) => Some(target.as_str()), | ||
| Some(None) => { | ||
| tracing::error!(target: "neard", "--verbose flag is deprecated, please use RUST_LOG or log_config.json instead."); | ||
| Some("") | ||
| } | ||
| Some(Some(ref target)) => { | ||
| tracing::error!(target: "neard", "--verbose flag is deprecated, please use RUST_LOG or log_config.json instead."); | ||
| Some(target.as_str()) | ||
| } | ||
| } |
There was a problem hiding this comment.
self.verbose.as_ref().map(|arg| {
tracing::error!(target: "neard", "--verbose flag is deprecated, please use RUST_LOG or log_config.json instead.");
arg.map_or("", String::as_str)
})?
Ekleog-NEAR
approved these changes
Sep 21, 2023
--verbose is not a bool, but a String argument, which is confusing.
nikurt
added a commit
that referenced
this pull request
Sep 22, 2023
* Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing. * Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing. * Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing.
nikurt
added a commit
that referenced
this pull request
Sep 26, 2023
* Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing. * Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing. * Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing.
nikurt
added a commit
that referenced
this pull request
Sep 26, 2023
* Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing. * Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing. * Logging: Deprecate --verbose --verbose is not a bool, but a String argument, which is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--verboseis not abool, but aStringargument, which is confusing.