[cleanup] Remove redundant pattern of manually creating store, epoch manager, runtime in integration tests #9595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .epoch_managers(epoch_managers) | ||
| .runtimes(runtimes) | ||
| .clients_count(2) | ||
| .real_stores() |
There was a problem hiding this comment.
what does 'real' mean here? Is there non-real version of it?
There was a problem hiding this comment.
We have a test_store, i.e. in-memory store and we have a "real" store which is rocksdb on disk. This could be an appropriate name as we have things like real_epoch_managers function to "not create mock epoch managers"
robin-near
approved these changes
Sep 26, 2023
nikurt
pushed a commit
that referenced
this pull request
Oct 2, 2023
…manager, runtime in integration tests (#9595) We had a common pattern of creating a bunch of manual stores, epoch managers, and nightshade runtime for the test environment. This PR brings the default functionality to the test environment builder.
nikurt
pushed a commit
that referenced
this pull request
Oct 2, 2023
…manager, runtime in integration tests (#9595) We had a common pattern of creating a bunch of manual stores, epoch managers, and nightshade runtime for the test environment. This PR brings the default functionality to the test environment builder.
nikurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
…manager, runtime in integration tests (#9595) We had a common pattern of creating a bunch of manual stores, epoch managers, and nightshade runtime for the test environment. This PR brings the default functionality to the test environment builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a common pattern of creating a bunch of manual stores, epoch managers, and nightshade runtime for the test environment. This PR brings the default functionality to the test environment builder.