prefetch: remove code for prefetching claim.sweat::claim #11329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweat coin has migrated to new data structures that seem to require fewer storage accesses. Regardless the current prefetcher no longer works, so lets remove it.
|
I'm about to spin up a node to verify the impact of this change, if any. Until then this should not be merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11329 +/- ##
==========================================
+ Coverage 71.04% 71.09% +0.05%
==========================================
Files 782 783 +1
Lines 156618 156794 +176
Branches 156618 156794 +176
==========================================
+ Hits 111264 111471 +207
+ Misses 40533 40490 -43
- Partials 4821 4833 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tayfunelmas
approved these changes
May 16, 2024
|
I have reviewed the graphs and they indicate no notable (perhaps very slightly better: the shard cache hit rate is better) behaviour compared to the current nodes. This is good to merge, as we've verified that the code is dead for sure with the experiment. |
posvyatokum
pushed a commit
that referenced
this pull request
Jun 11, 2024
Sweat coin has migrated to new data structures that seem to require fewer storage accesses. Regardless the current prefetcher no longer works, so lets remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweat coin has migrated to new data structures that seem to require fewer storage accesses. Regardless the current prefetcher no longer works, so lets remove it.
Fixes #11327