8000 sweat: update prefetcher for record_batch_for_hold by nagisa · Pull Request #11338 · near/nearcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sweat: update prefetcher for record_batch_for_hold #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2024
Merged

sweat: update prefetcher for record_batch_for_hold #11338

merged 1 commit into from
May 17, 2024

Conversation

nagisa
Copy link
Collaborator
@nagisa nagisa commented May 17, 2024

Fixes #11328

@nagisa nagisa requested a review from a team as a code owner May 17, 2024 10:22
@nagisa nagisa requested a review from akhi3030 May 17, 2024 10:22
@nagisa
Copy link
Collaborator Author
nagisa commented May 17, 2024

Not yet tested... should not merge.

@nagisa
Copy link
Collaborator Author
nagisa commented May 17, 2024

This looks really good:

old apply latency graph showing periodic p99 applies that exceed 1 second
new apply latency graph showing a much more consistent p99 performance

@nagisa nagisa force-pushed the prefetch-sweat-record_batch_for_hold branch from 75da178 to 1f04750 Compare May 17, 2024 12:26
@nagisa nagisa enabled auto-merge May 17, 2024 12:26
@nagisa nagisa added this pull request to the merge queue May 17, 2024
@codecov Codecov
Copy link
codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 71.07%. Comparing base (fc6b1cf) to head (1f04750).

Files Patch % Lines
runtime/runtime/src/prefetch.rs 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11338      +/-   ##
==========================================
- Coverage   71.07%   71.07%   -0.01%     
==========================================
  Files         783      783              
  Lines      156719   156720       +1     
  Branches   156719   156720       +1     
==========================================
- Hits       111394   111385       -9     
- Misses      40502    40512      +10     
  Partials     4823     4823
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (-0.01%) ⬇️
db-migration 0.24% <0.00%> (-0.01%) ⬇️
genesis-check 1.39% <0.00%> (-0.01%) ⬇️
integration-tests 37.14% <0.00%> (-0.02%) ⬇️
linux 68.99% <0.00%> (-0.01%) ⬇️
linux-nightly 70.52% <0.00%> (-0.01%) ⬇️
macos 52.45% <0.00%> (+0.02%) ⬆️
pytests 1.61% <0.00%> (-0.01%) ⬇️
sanity-checks 1.40% <0.00%> (-0.01%) ⬇️
unittests 65.50% <0.00%> (-0.01%) ⬇️
upgradability 0.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit ef83c4d May 17, 2024
27 of 29 checks passed
@nagisa nagisa deleted the prefetch-sweat-record_batch_for_hold branch May 17, 2024 13:01
VanBarbascu pushed a commit that referenced this pull request May 22, 2024
@nagisa @VanBarbascu
sweat: update prefetcher for record_batch_for_hold (#11338)
bc70aea 
Fixes #11328
posvyatokum pushed a commit that referenced this pull request Jun 11, 2024
@nagisa @posvyatokum
sweat: update prefetcher for record_batch_for_hold (#11338)
1ce8f03 
Fixes #11328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhi3030 akhi3030 akhi3030 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate periodic spikes in P99 chunk apply latency on shard 2
2 participants
@nagisa @akhi3030
0