8000 Increase the default Slurm MessageTimeout by rdjjke · Pull Request #460 · nebius/soperator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Increase the default Slurm MessageTimeout #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Increase the default Slurm MessageTimeout #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8491ef3
NOTIC: Speedup large clusters bootstrap by making ldconfig flock non-…
rdjjke Feb 18, 2025
80be152
NOTIC: Make MessageTimeout configurable and increase the default 10 -…
rdjjke Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations 8000
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.18.1
1.18.2
6 changes: 6 additions & 0 deletions api/v1/slurmcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@ type SlurmConfig struct {
// +kubebuilder:validation:Optional
// +kubebuilder:default=86400
MinJobAge *int32 `json:"minJobAge,omitempty"`
// MessageTimeout specifies the permitted time for a round-trip communication to complete in seconds.
// See https://slurm.schedmd.com/slurm.conf.html#OPT_MessageTimeout.
//
// +kubebuilder:validation:Optional
// +kubebuilder:default=30
MessageTimeout *int32 `json:"messageTimeout,omitempty"`
}

type MPIConfig struct {
Expand Down
5 changes: 5 additions & 0 deletions api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions config/crd/bases/slurm.nebius.ai_slurmclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,6 +1541,13 @@ spec:
description: Keep N last jobs in controller memory
format: int32
type: integer
messageTimeout:
default: 30
description: |-
MessageTimeout specifies the permitted time for a round-trip communication to complete in seconds.
See https://slurm.schedmd.com/slurm.conf.html#OPT_MessageTimeout.
format: int32
type: integer
minJobAge:
default: 86400
description: Don't remove jobs from controller memory after some
Expand Down Expand Up @@ -1907,12 +1914,12 @@ spec:
- type: string
description: Size of the PVCs to be mounted by MariaDB.
Required if not provided in 'VolumeClaimTemplate'.
It supersedes the storage size specified in 'VolumeClaimTemplate'.
It superseeds the storage size specified in 'VolumeClaimTemplate'.
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
storageClassName:
description: |-
StorageClassName to be used to provision the PVCS. It supersedes the 'StorageClassName' specified in 'VolumeClaimTemplate'.
StorageClassName to be used to provision the PVCS. It superseeds the 'StorageClassName' specified in 'VolumeClaimTemplate'.
If not provided, the default 'StorageClass' configured in the cluster is used.
type: string
volumeClaimTemplate:
Expand Down
2 changes: 1 addition & 1 deletion config/manager/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ resources:
images:
- name: controller
newName: cr.eu-north1.nebius.cloud/soperator/slurm-operator
newTag: 1.18.1
newTag: 1.18.2
2 changes: 1 addition & 1 deletion config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ spec:
value: "false"
- name: SLURM_OPERATOR_WATCH_NAMESPACES
value: "*"
image: controller:1.18.1
image: controller:1.18.2
imagePullPolicy: Always
name: manager
securityContext:
Expand Down
4 changes: 2 additions & 2 deletions helm/slurm-cluster-storage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: helm-slurm-cluster-storage
description: A Helm chart for Kubernetes
type: application
version: "1.18.1"
appVersion: "1.18.1"
version: "1.18.2"
appVersion: "1.18.2"
4 changes: 2 additions & 2 deletions helm/slurm-cluster/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: helm-slurm-cluster
description: A Helm chart for Kubernetes
type: application
version: "1.18.1"
appVersion: "1.18.1"
version: "1.18.2"
appVersion: "1.18.2"
kubeVersion: ">=1.29.0-0"
18 changes: 9 additions & 9 deletions helm/slurm-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,14 +408,14 @@ telemetry: {}
# otelCollectorPort: 8429

images:
slurmctld: "cr.eu-north1.nebius.cloud/soperator/controller_slurmctld:1.18.1-jammy-slurm24.05.5"
slurmrestd: "cr.eu-north1.nebius.cloud/soperator/slurmrestd:1.18.1-jammy-slurm24.05.5"
slurmd: "cr.eu-north1.nebius.cloud/soperator/worker_slurmd:1.18.1-jammy-slurm24.05.5"
sshd: "cr.eu-north1.nebius.cloud/soperator/login_sshd:1.18.1-jammy-slurm24.05.5"
munge: "cr.eu-north1.nebius.cloud/soperator/munge:1.18.1-jammy-slurm24.05.5"
populateJail: "cr.eu-north1.nebius.cloud/soperator/populate_jail:1.18.1-jammy-slurm24.05.5"
ncclBenchmark: "cr.eu-north1.nebius.cloud/soperator/nccl_benchmark:1.18.1-jammy-slurm24.05.5"
slurmdbd: "cr.eu-north1.nebius.cloud/soperator/controller_slurmdbd:1.18.1-jammy-slurm24.05.5"
exporter: "cr.eu-north1.nebius.cloud/soperator/exporter:1.18.1-jammy-slurm24.05.5"
slurmctld: "cr.eu-north1.nebius.cloud/soperator/controller_slurmctld:1.18.2-jammy-slurm24.05.5"
slurmrestd: "cr.eu-north1.nebius.cloud/soperator/slurmrestd:1.18.2-jammy-slurm24.05.5"
slurmd: "cr.eu-north1.nebius.cloud/soperator/worker_slurmd:1.18.2-jammy-slurm24.05.5"
sshd: "cr.eu-north1.nebius.cloud/soperator/login_sshd:1.18.2-jammy-slurm24.05.5"
munge: "cr.eu-north1.nebius.cloud/soperator/munge:1.18.2-jammy-slurm24.05.5"
populateJail: "cr.eu-north1.nebius.cloud/soperator/populate_jail:1.18.2-jammy-slurm24.05.5"
ncclBenchmark: "cr.eu-north1.nebius.cloud/soperator/nccl_benchmark:1.18.2-jammy-slurm24.05.5"
slurmdbd: "cr.eu-north1.nebius.cloud/soperator/controller_slurmdbd:1.18.2-jammy-slurm24.05.5"
exporter: "cr.eu-north1.nebius.cloud/soperator/exporter:1.18.2-jammy-slurm24.05.5"
mariaDB: "docker-registry1.mariadb.com/library/mariadb:11.4.3"
rebooter: "cr.eu-north1.nebius.cloud/soperator/rebooter:1.17.0"
4 changes: 2 additions & 2 deletions helm/soperator-crds/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: helm-soperator-crds
description: A Helm chart for Kubernetes
type: application
version: 1.18.1
appVersion: "1.18.1"
version: 1.18.2
appVersion: "1.18.2"
kubeVersion: ">=1.29.0-0"
11 changes: 9 additions & 2 deletions helm/soperator-crds/templates/slurmcluster-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6088,6 +6088,13 @@ spec:
description: Keep N last jobs in controller memory
format: int32
type: integer
messageTimeout:
default: 30
description: |-
MessageTimeout specifies the permitted time for a round-trip communication to complete in seconds.
See https://slurm.schedmd.com/slurm.conf.html#OPT_MessageTimeout.
format: int32
type: integer
minJobAge:
default: 86400
description: Don't remove jobs from controller memory after some
Expand Down Expand Up @@ -6454,12 +6461,12 @@ spec:
- type: string
description: Size of the PVCs to be mounted by MariaDB.
Required if not provided in 'VolumeClaimTemplate'.
It supersedes the storage size specified in 'VolumeClaimTemplate'.
It superseeds the storage size specified in 'VolumeClaimTemplate'.
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
storageClassName:
description: |-
StorageClassName to be used to provision the PVCS. It supersedes the 'StorageClassName' specified in 'VolumeClaimTemplate'.
StorageClassName to be used to provision the PVCS. It superseeds the 'StorageClassName' specified in 'VolumeClaimTemplate'.
If not provided, the default 'StorageClass' configured in the cluster is used.
type: string
volumeClaimTemplate:
Expand Down
4 changes: 2 additions & 2 deletions helm/soperator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: helm-soperator
description: A Helm chart for Kubernetes
type: application
version: 1.18.1
appVersion: "1.18.1"
version: 1.18.2
appVersion: "1.18.2"
kubeVersion: ">=1.29.0-0"
11 changes: 9 additions & 2 deletions helm/soperator/crds/slurmcluster-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6088,6 +6088,13 @@ spec:
description: Keep N last jobs in controller memory
format: int32
type: integer
messageTimeout:
default: 30
description: |-
MessageTimeout specifies the permitted time for a round-trip communication to complete in seconds.
See https://slurm.schedmd.com/slurm.conf.html#OPT_MessageTimeout.
format: int32
type: integer
minJobAge:
default: 86400
description: Don't remove jobs from controller memory after some
Expand Down Expand Up @@ -6454,12 +6461,12 @@ spec:
- type: string
description: Size of the PVCs to be mounted by MariaDB.
Required if not provided in 'VolumeClaimTemplate'.
It supersedes the storage size specified in 'VolumeClaimTemplate'.
It superseeds the storage size specified in 'VolumeClaimTemplate'.
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
storageClassName:
description: |-
StorageClassName to be used to provision the PVCS. It supersedes the 'StorageClassName' specified in 'VolumeClaimTemplate'.
StorageClassName to be used to provision the PVCS. It superseeds the 'StorageClassName' specified in 'VolumeClaimTemplate'.
If not provided, the default 'StorageClass' configured in the cluster is used.
type: string
volumeClaimTemplate:
Expand Down
2 changes: 1 addition & 1 deletion helm/soperator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ controllerManager:
slurmOperatorWatchNamespaces: '*'
image:
repository: cr.eu-north1.nebius.cloud/soperator/slurm-operator
tag: 1.18.1
tag: 1.18.2
imagePullPolicy: Always
resources:
limits:
Expand Down
2 changes: 1 addition & 1 deletion images/common/scripts/complement_jail.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ pushd "${jaildir}"
# For worker node only
if [ -n "$worker" ]; then
echo "Update linker cache inside the jail"
flock etc/complement_jail_ldconfig.lock -c "chroot \"${jaildir}\" /usr/sbin/ldconfig"
flock --nonblock etc/complement_jail_ldconfig.lock -c "chroot \"${jaildir}\" /usr/sbin/ldconfig" && true

# slurmd package tree https://gist.github.com/asteny/9eb5089a10a793834d12a5b2449cc2b9
echo "Bind-mount slurmd binaries from container to the jail"
Expand Down
2 changes: 1 addition & 1 deletion internal/consts/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
package consts

const (
VersionCR = "1.18.1"
VersionCR = "1.18.2"
)
Loading
0