8000 fix: matrix expansion logic by ChristopherHX · Pull Request #5294 · nektos/act · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: matrix expansion logic #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: matrix expansion logic #5294

wants to merge 1 commit into from

Conversation

ChristopherHX
Copy link
Contributor

  • add another test

  • remove //nolint:gocyclo

TODO check if the test in https://github.com/nektos/act/blob/162671cb083609e531939db62cf6b176d6d5a376/pkg/model/workflow_test.go could be merged here

@ChristopherHX @github-actions
fix: matrix expansion logic (nektos#115)
33bff06 
* add another test

* remove //nolint:gocyclo
@ChristopherHX ChristopherHX changed the title fix: matrix expansion logic (#115) fix: matrix expansion logic Jun 12, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (bd4bc99) to head (33bff06).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
pkg/model/workflow.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
+ Coverage   74.65%   74.78%   +0.13%     
==========================================
  Files          73       73              
  Lines       11139    11170      +31     
==========================================
+ Hits         8316     8354      +38     
+ Misses       2186     2180       -6     
+ Partials      637      636       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristopherHX ChristopherHX marked this pull request as ready for review June 13, 2025 11:33
@ChristopherHX
Copy link
Contributor Author

The new test case of #2649 can be pulled after this changed and it succeeds.

@ChristopherHX
Copy link
Contributor Author
ChristopherHX commented Jun 13, 2025 •
edited
Loading

Summary, I forget to remove old code that messed up my newer code. Most likely due to an invalid test case that is changed in both this and linked older PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChristopherHX
0