8000 Fix github SSH regex for missing .git extension by michaelbeaumont · Pull Request #871 · nektos/act · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix github SSH regex for missing .git extension #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2021
Merged

Fix github SSH regex for missing .git extension #871

merged 3 commits into from
Nov 13, 2021

Conversation

michaelbeaumont
Copy link
Contributor

Of course the same issue fixed in #34 exists for SSH URLs.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 12, 2021 19:58
@catthehacker
Copy link
Member

Could you add a testcase for it?

@mergify

This comment has been minimized.

Sign in to view
@mergify mergify bot added the needs-work Extra attention is needed label Nov 12, 2021
@catthehacker

This comment has been minimized.

Sign in to view
@michaelbeaumont
Copy link
Contributor Author

@catthehacker thanks! done

@codecov
Copy link
codecov bot commented Nov 13, 2021 •
edited
Loading

Codecov Report

Merging #871 (a8faea5) into master (0f04942) will increase coverage by 7.01%.
The diff coverage is 61.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   49.27%   56.28%   +7.01%     
==========================================
  Files          23       25       +2     
  Lines        2401     3948    +1547     
==========================================
+ Hits         1183     2222    +1039     
- Misses       1090     1525     +435     
- Partials      128      201      +73
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 5.56% <15.09%> (+3.63%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_build.go 58.97% <50.00%> (+58.97%) ⬆️
pkg/container/docker_pull.go 35.29% <61.53%> (+17.11%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/artifacts/server.go 67.32% <67.32%> (ø)
pkg/runner/runner.go 74.46% <70.37%> (-2.01%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3054f3e...a8faea5. Read the comment docs.

@mergify mergify bot removed the needs-work Extra attention is needed label Nov 13, 2021
@mergify mergify bot requested a review from a team November 13, 2021 13:51
@mergify mergify bot merged commit 62d2167 into nektos:master Nov 13, 2021
@catthehacker
Copy link
Member

@michaelbeaumont thanks for contributing ❤️

@michaelbeaumont michaelbeaumont deleted the patch-1 branch November 13, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cplee cplee cplee approved these changes

@catthehacker catthehacker catthehacker approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @catthehacker @cplee
0