8000 fix: github.job property is empty, GITHUB_JOB should be job id by alex-savchuk · Pull Request #1646 · nektos/act · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: github.job property is empty, GITHUB_JOB should be job id #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2023
Merged

fix: github.job property is empty, GITHUB_JOB should be job id #1646

merged 3 commits into from
Feb 27, 2023

Conversation

alex-savchuk
Copy link
Contributor

fix: github.job property is empty #1621
fix: GITHUB_JOB should be the id not the name #1473

@alex-savchuk
fix: github.job property is empty, GITHUB_JOB should be job id
8000
4796f2d 
fix: github.job property is empty nektos#1621
fix: GITHUB_JOB should be the id not the name nektos#1473
@alex-savchuk alex-savchuk requested a review from a team as a code owner February 23, 2023 04:25
@mergify
Copy link
Contributor
mergify bot commented Feb 23, 2023

@alex-savchuk this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Feb 23, 2023
@codecov
Copy link
codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #1646 (0e3df42) into master (4989f44) will increase coverage by 1.17%.
The diff coverage is 70.63%.

@@            Coverage Diff             @@
##           master    #1646      +/-   ##
==========================================
+ Coverage   61.22%   62.39%   +1.17%     
==========================================
  Files          46       48       +2     
  Lines        7141     7435     +294     
==========================================
+ Hits         4372     4639     +267     
- Misses       2462     2477      +15     
- Partials      307      319      +12
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <ø> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/interpreter.go 72.54% <0.00%> (-0.84%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor
mergify bot commented Feb 23, 2023

@alex-savchuk this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Feb 23, 2023
@mergify mergify bot merged commit 5500c92 into nektos:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnisterPeter KnisterPeter KnisterPeter approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-savchuk @KnisterPeter @ChristopherHX
0