8000 Add example command for collecting artifacts by Yann-P · Pull Request #1671 · nektos/act · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add example command for collecting artifacts #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 19, 2023
Merged

Add example command for collecting artifacts #1671

merged 5 commits into from
Mar 19, 2023

Conversation

Yann-P
Copy link
Contributor
@Yann-P Yann-P commented Mar 8, 2023

As a beginner with act, it took me some time to find this comment and figure out how to access the artifacts #329 (comment).

I had read --help but it was not clear that an artifact server was included and thought I had to provide an URI to an external service.

So I suggest adding this small example -- alternatively add a note to the wiki

@Yann-P Yann-P requested a review from a team as a code owner March 8, 2023 14:47
@mergify
Copy link
Contributor
mergify bot commented Mar 14, 2023

@Yann-P this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Mar 14, 2023
@Yann-P
Copy link
Contributor Author
Yann-P commented Mar 17, 2023

@KnisterPeter can you approve the workflow again please?

@ChristopherHX
Copy link
Contributor

Please note documentation is moving

https://nektosact.com/beginner/index.html

@codecov
Copy link
codecov bot commented Mar 19, 2023

Codecov Report

Merging #1671 (3d52e49) into master (4989f44) will increase coverage by 1.59%.
The diff coverage is 74.20%.

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
+ Coverage   61.22%   62.81%   +1.59%     
==========================================
  Files          46       48       +2     
  Lines        7141     7479     +338     
==========================================
+ Hits         4372     4698     +326     
+ Misses       2462     2461       -1     
- Partials      307      320      +13
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Mar 19, 2023
@mergify mergify bot merged commit 35cac27 into nektos:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnisterPeter KnisterPeter KnisterPeter approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yann-P @ChristopherHX @KnisterPeter
0