8000 fix: ghc assignment typo by ChristopherHX · Pull Request #1729 · nektos/act · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ghc assignment typo #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2023
Merged

fix: ghc assignment typo #1729

merged 3 commits into from
Apr 13, 2023

Conversation

ChristopherHX
Copy link
Contributor

No description provided.

@ChristopherHX ChristopherHX requested a review from a team as a code owner April 13, 2023 13:17
@github-actions
Copy link
Contributor
github-actions bot commented Apr 13, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.02s
✅ REPOSITORY gitleaks yes no 2.58s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.17s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

ZauberNerd
ZauberNerd suggested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor
@ZauberNerd ZauberNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, there are more issues..
There shouldn't be a space here: https://github.com/nektos/act/pull/1727/files#diff-09c4c54785c83a96af05eedd3040aa4f5866bc86a8a5dedc500fa13ccb83e54cR39

ZauberNerd
ZauberNerd approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor
@ZauberNerd ZauberNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks!

@ChristopherHX
Copy link
Contributor Author

Next time look deeper, patched this one too

@mergify
Copy link
Contributor
mergify bot commented Apr 13, 2023

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Apr 13, 2023
@codecov
Copy link
codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #1729 (f8c93cd) into master (4989f44) will increase coverage by 1.26%.
The diff coverage is 69.27%.

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   61.22%   62.49%   +1.26%     
==========================================
  Files          46       48       +2     
  Lines        7141     7524     +383     
==========================================
+ Hits         4372     4702     +330     
- Misses       2462     2501      +39     
- Partials      307      321      +14
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.01% <0.00%> (-0.11%) ⬇️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Apr 13, 2023
@mergify mergify bot merged commit 97749a2 into master Apr 13, 2023
@mergify mergify bot deleted the ghc-assignment-typo branch April 13, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZauberNerd ZauberNerd ZauberNerd approved these changes

@KnisterPeter KnisterPeter KnisterPeter approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherHX @ZauberNerd @KnisterPeter
0