fix: ensure networkmode "host" unless explicitly specified #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
act defaults network mode to "host", but when `--container-options` are passed on the CLI, it uses the docker CLI options parser, which fills empty values with defaults, in which case network mode is set to "default". Unless the user explicitly sets `--container-options="--network=xxx"`, we should always default to "host", to keep act's behaviour. Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
KnisterPeter
approved these changes
Apr 18, 2023
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
|
@ZauberNerd this pull request has failed checks 🛠 |
Downloading node.js from nodejs.org failed with an HTTP error 500. Retriggering the test-linux checks fixed it. |
Codecov Report
@@ Coverage Diff @@
## master #1739 +/- ##
==========================================
+ Coverage 61.22% 62.41% +1.18%
==========================================
Files 46 48 +2
Lines 7141 7537 +396
==========================================
+ Hits 4372 4704 +332
- Misses 2462 2509 +47
- Partials 307 324 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cplee
approved these changes
Apr 18, 2023
makrsmark
pushed a commit
to makrsmark/act
that referenced
this pull request
Aug 3, 2023
In [nektos/pull/1739](nektos#1739), the container network mode defaults to `host` if the network option isn't specified in `options`. When calling `ConnectToNetwork`, the `host` network mode may cause the error: `Error response from daemon: container sharing network namespace with another container or host cannot be connected to any other network` see the code: https://gitea.com/gitea/act/src/commit/a94a01bff2576fcf9fefaf879ea09c11e383cdab/pkg/container/docker_run.go#L51-L68 To avoid the error, this logic needs to be removed to keep the default network mode as `bridge`. Reviewed-on: https://gitea.com/gitea/act/pulls/55 Reviewed-by: Jason Song <i@wolfogre.com> Co-authored-by: Zettat123 <zettat123@gmail.com> Co-committed-by: Zettat123 <zettat123@gmail.com>
badeball
added a commit
to badeball/cypress-cucumber-preprocessor
that referenced
this pull request
Apr 28, 2024
Using `act` [1]. However, act uses network mode `host` by default [2]. Multiple Cypress instances will check for X and start it, concurrently and not in an atomic way, causing issues. Container options specified in workflows and using --container-options *aren't* merged [3]. Furthermore, specifying a network option that works both on GHA and locally appears to be a bit tricky [4]. Thus, using `xvfb-run` to create a shared fb appears to be the easiest solution. However, `act` doesn't support env pass through, so we must parse `$DISPLAY` inside the xvfb environment in order to explicitly provide it to `act`. This would have all been unnecessary if `ELECTRON_RUN_AS_NODE` had even remotely worked [5]. [1] https://nektosact.com/ [2] nektos/act#1739 [3] nektos/act#1696 [4] nektos/act#1740 [5] cypress-io/cypress-documentation#5666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
act defaults network mode to "host", but when
--container-optionsare passed on the CLI, it uses the docker CLI options parser, which fills empty values with defaults, in which case network mode is set to "default".Unless the user explicitly sets
--container-options="--network=xxx", we should always default to "host", to keep act's behaviour.