8000 feat: implement steps.timeout-minutes by ChristopherHX · Pull Request #1776 · nektos/act · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: implement steps.timeout-minutes #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2023
Merged

feat: implement steps.timeout-minutes #1776

merged 5 commits into from
May 3, 2023

Conversation

ChristopherHX
Copy link
Contributor

@github-actions
Copy link
Contributor
github-actions bot commented May 1, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.87s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 1.62s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #1776 (27d2846) into master (4989f44) will increase coverage by 1.27%.
The diff coverage is 64.91%.

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
+ Coverage   61.22%   62.50%   +1.27%     
==========================================
  Files          46       51       +5     
  Lines        7141     8150    +1009     
==========================================
+ Hits         4372     5094     +722     
- Misses       2462     2668     +206     
- Partials      307      388      +81
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_run.go 13.58% <0.00%> (-0.01%) ⬇️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.44% <9.09%> (+0.32%) ⬆️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChristopherHX ChristopherHX marked this pull request as ready for review May 1, 2023 19:20
@ChristopherHX ChristopherHX requested a review from a team as a code owner May 1, 2023 19:20
KnisterPeter
KnisterPeter approved these changes May 3, 2023
View reviewed changes
Copy link
Member
@KnisterPeter KnisterPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look nice 🎉
I would prefer if you add a test, but I'll approve anyway.

@mergify
Copy link
Contributor
mergify bot commented May 3, 2023

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label May 3, 2023
@mergify mergify bot removed the needs-work Extra attention is needed label May 3, 2023
@mergify mergify bot merged commit 8913375 into master May 3, 2023
@mergify mergify bot deleted the feat-step-timeout-minutes branch May 3, 2023 18:08
@ChristopherHX
Copy link
Contributor Author

I would prefer if you add a test

I will create some positive tests later.
Like a sleep of 70s with continue-on-error and a check for a failed attempt.

Until we change the type of the property to yaml.Node we cannot say if the timeout number has been a string or a number.
A number provided as a string will cause an error in Github Actions, but not in act.

I have more small changes next to this one in my rebased fork, e.g. adding a graceful cancel mode (making cancelled() == true) and allowing running normal steps after graceful cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnisterPeter KnisterPeter KnisterPeter approved these changes

@cplee cplee cplee approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherHX @KnisterPeter @cplee
0