Bump dependencies #787
Merged
Bump dependencies #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveleif
commented
May 16, 2025
Comment on lines
+63
to
+64
| // We want the same netty version as other neo4j dependencies, are there better ways than to keep this in sync? | ||
| implementation(enforcedPlatform('io.netty:netty-bom:4.2.1.Final')) |
There was a problem hiding this comment.
No idea what I'm doing. Are there better ways?
There was a problem hiding this comment.
Will this start failing if there is a different version in the monorepo?
There was a problem hiding this comment.
Not as far as I know, it will force the netty version to be consistent though I believe (netty consists of multiple dependencies).
JoelBergstrand
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some flaky tests.