8000 Add pagination to gitlab registry by chodorenko · Pull Request #1798 · neuvector/neuvector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Add pagination to gitlab registry #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chodorenko
Copy link

Fix for pagination Issue #1797
Need review

@chodorenko chodorenko requested review from yasker and a team as code owners February 5, 2025 16:23
@holyspectral
Copy link
Collaborator

@chodorenko thanks for contributing! The PR looks good to me. We will just have some quick tests.

@chodorenko
Copy link
Author

I attempted to build a test release of allinone to validate my patch, but unfortunately, I couldn't figure out how to do it. The build scripts rely on external images, but I couldn't find any instructions or methods to assemble them.

There is also an open issue: GitHub Issue #24. If you want the community to contribute to the development and troubleshooting of the product, perhaps it’s time to address this matter.

Is there any documentation or guidelines available on setting up a test environment and building the project for testing changes before submitting a PR?

@holyspectral
Copy link
Collaborator

@chodorenko We're doing some refactoring about how our images are built. In the meantime, the documentation might not be very clear.

Could you please take a look at the allinone's Dockerfile to see if it would help? You would need a manager, a controller and an enforcer image with the same tag. (You can generate that by using manager's Dockerfile, controller's Dockerfile and enforcer's Dockerfile.

771D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0