8000 chore(deps): update module github.com/docker/docker to v28 by renovate-rancher[bot] · Pull Request #1830 · neuvector/neuvector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(deps): update module github.com/docker/docker to v28 #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

chore(deps): update module github.com/docker/docker to v28 #1830

merged 2 commits into from
Mar 28, 2025

Conversation

renovate-rancher[bot]
Copy link
Contributor
@renovate-rancher renovate-rancher bot commented Feb 20, 2025 •
edited by holyspectral
Loading

This PR contains the following updates:

Package Type Update Change
github.com/docker/docker require major v26.1.5+incompatible -> v28.0.1+incompatible

Release Notes

docker/docker (github.com/docker/docker)

v28.0.1+incompatible

Compare Source

v28.0.0+incompatible

Compare Source

v27.5.1+incompatible

Compare Source

v27.5.0+incompatible

Compare Source

v27.4.1+incompatible

Compare Source

v27.4.0+incompatible

Compare Source

v27.3.1+incompatible

Compare Source

v27.3.0+incompatible

Compare Source

v27.2.1+incompatible

Compare Source

v27.2.0+incompatible

Compare Source

v27.1.2+incompatible

Compare Source

v27.1.1+incompatible

Compare Source

v27.1.0+incompatible

Compare Source

v27.0.3+incompatible

Compare Source

v27.0.2+incompatible

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@renovate-rancher renovate-rancher bot force-pushed the renovate/github.com-docker-docker-28.x branch from d46ac3e to 6186d38 Compare February 27, 2025 04:40
@renovate-rancher renovate-rancher bot changed the title chore(deps): update module github.com/docker/docker to v28 Update module github.com/docker/docker to v28 Feb 27, 2025
@renovate-rancher renovate-rancher bot changed the title Update module github.com/docker/docker to v28 chore(deps): update module github.com/docker/docker to v28 Mar 8, 2025
@renovate-rancher renovate-rancher bot force-pushed the renovate/github.com-docker-docker-28.x branch from 6186d38 to 1dac58b Compare March 12, 2025 18:03
@holyspectral holyspectral requested a review from a team as a code owner March 20, 2025 13:29
@holyspectral holyspectral self-requested a review March 20, 2025 13:29
@holyspectral holyspectral force-pushed the renovate/github.com-docker-docker-28.x branch from 9134c99 to 7cd83df Compare March 20, 2025 16:16
@holyspectral
Copy link
Collaborator
holyspectral commented Mar 20, 2025 •
edited
Loading

Hi @jayhuang-suse could you help to double check my fix for the build error? 7cd83df

ImageInspectWithRaw() is deprecated, so it was moved to ImageInspect(). It's basically the same implementation with the original one under the hood, so there shouldn't be backward-compatibility issue.

resp, err := cli.get(ctx, "/images/"+imageID+"/json", query, nil)

https://github.com/moby/moby/blob/411e817ddf710ff8e08fa193da80cb78af708191/client/image_inspect.go#L17

jayhuang-suse
jayhuang-suse requested changes Mar 21, 2025
View reviewed changes
Copy link
Contributor
@jayhuang-suse jayhuang-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageInspectWithRaw returns the image information and its raw representation.

Deprecated: Use Client.ImageInspect instead. Raw response can be obtained using the ImageInspectWithRawResponse option.

The option needs to be included to behaved correctly.

@holyspectral
Copy link
Collaborator

Hi @jayhuang-suse , we don't use raw data at all in the existing implementation. That's why we don't need to include the option.

@renovate-rancher renovate-rancher
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jayhuang-suse
Copy link
Contributor

We are still using this function on obtaining container's image data. The new API function expands it capability to handle the results. Without the option, it would be get a unexpected "json" result without the suggestive option. That is why docker put the query suggestion of the obsoleted function.

https://github.com/moby/moby/blob/bea4de25004da0460f80ac1e0f1628e66b058287/client/image_inspect.go#L20

It is better that we can get the same result as before.

@holyspectral
Copy link
Collaborator

Hi @jayhuang-suse as we communicated privately, please feel free to let me know if you still have concerns.

jayhuang-suse
jayhuang-suse approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor
@jayhuang-suse jayhuang-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be affected by current docker engine release as it could be a default query option. It needs to be watched if it gets the unexpected image result in its future release.

@holyspectral holyspectral merged commit f74c427 into main Mar 28, 2025
7 checks passed
@holyspectral holyspectral deleted the renovate/github.com-docker-docker-28.x branch March 28, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holyspectral holyspectral holyspectral approved these changes

@jayhuang-suse jayhuang-suse jayhuang-suse approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holyspectral @jayhuang-suse
0