NVSHAS-9940: NV scan JFrog Subdomain mode issue #2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c879fa to
acf32f6
Compare
controller/scan/jfrog.go
Outdated
| key, repository, found := strings.Cut(repositoryStr, "/") | ||
| if !found { | ||
| return tags, fmt.Errorf("invalid repository format: %v", repositoryStr) | ||
| key := r.subdomainInRegURL |
There was a problem hiding this comment.
If JFrog is not using the sub-domain style right now, will this branch still work?
In that case the key will be empty.
Suggestion: We could branch the logic explicitly by mode:
if r.mode == share.JFrogModeSubdomain {
// handle sub-domain scenario
} else {
// existing path for path-style or default mode
}This makes the intent clear and prevents nil/empty-key issues when the registry is in the “path-style” mode.
what do you think?
There was a problem hiding this comment.
ok. changed code as advised
ac11749 to
e1a1fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.