8000 Fix missing 'dev' tag in bumped version by Daniel-VM · Pull Request #152 · nf-core/bacass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing 'dev' tag in bumped version #152

New issue

< 8000 strong>Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix missing 'dev' tag in bumped version #152

merged 1 commit into from
Jul 10, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

Just a PR fixing missing dev version by bumping 2.4.0dev.

I have realized that dev version 2.4.0 didn't carry the tag "dev" since it hasn't been released yet.

@github-actions GitHub Actions
< 8000 /summary> Copy link
github-actions bot commented Jul 10, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit a49930e

+| ✅ 196 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-10 10:22:01

@Daniel-VM Daniel-VM marked this pull request as ready for review July 10, 2024 10:29
@d4straub
Copy link
Collaborator
d4straub commented Jul 10, 2024 •
edited
Loading

Indeed, the dev tag should be there. Usually there is a warning in nf-core lint about the missing dev tag, probably we need to be a little more careful when looking at them ;)

d4straub
d4straub approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator
@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4straub
Copy link
Collaborator

Looking at the tests, why
files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
?

@Daniel-VM
Copy link
Contributor Author

Indeed, the dev tag should be there. Usually there is a warning in nf-core lint about the missing dev tag, probably we need to be a little more careful when looking at them ;)

Absolutely 😅

Looking at the tests, why files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md ?

I thought nf-core/bacass didn't allow the -profile debug, but it actually does. So, this ignoring step aims to avoid nf-core linting errors while checking if those files differ from the TEMPLATE.

I am going to fix it in next PR.

@Daniel-VM Daniel-VM merged commit 24ec64c into nf-core:dev Jul 10, 2024
9 checks passed
@Daniel-VM
Copy link
Contributor Author

files_unchanged fixed here #153 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-VM @d4straub
0