8000 Fix wrong metadata in canu input channel by Daniel-VM · Pull Request #168 · nf-core/bacass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix wrong metadata in canu input channel #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix wrong metadata in canu input channel #168

merged 2 commits into from
Sep 18, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

This PR resolves an issue where the Canu module was not activated due to an incorrect variable name. The module requires the variable gsize, but genome_size was being used instead.

Closes #164

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 17, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit a65648e

+| ✅ 198 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-17 11:39:45

@Daniel-VM Daniel-VM mentioned this pull request Sep 17, 2024
Closed
@Daniel-VM Daniel-VM marked this pull request as ready for review September 17, 2024 11:40
@jfy133 jfy133 self-requested a review September 18, 2024 08:36
@Daniel-VM Daniel-VM merged commit 1cb4574 into nf-core:dev Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-VM @jfy133
0