8000 Merging template updates 3.0.2 by jannikseidelQBiC · Pull Request #42 · nf-core/detaxizer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merging template updates 3.0.2 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 16, 2024
Merged

Merging template updates 3.0.2 #42

merged 7 commits into from
Oct 16, 2024

Conversation

jannikseidelQBiC
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/detaxizer branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Template Update 3.0.2

d4straub
d4straub reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor
@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but the CHANGELOG should be updated including mentioning the now missing resource parameters and changed software versions.
However, I am no expert (yet) in the v3 versions of the template!

@jannikseidelQBiC
Copy link
Collaborator Author

@nf-core-bot fix linting

d4straub
d4straub approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor
@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me!

@jannikseidelQBiC jannikseidelQBiC merged commit 7c65d8b into nf-core:dev Oct 16, 2024
8 checks passed
@jannikseidelQBiC jannikseidelQBiC deleted the merging-template-updates branch October 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jannikseidelQBiC @d4straub @nf-core-bot @jannikseidel
0