8000 Merging template updates up to v2.1 by christopher-mohr · Pull Request #107 · nf-core/epitopeprediction · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merging template updates up to v2.1 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2021
Merged

Merging template updates up to v2.1 #107

merged 8 commits into from
Oct 29, 2021

Conversation

christopher-mohr
Copy link
Collaborator

PR checklist

@christopher-mohr
Copy link
Collaborator Author

This PR includes the merges of template v2.1 and will be the basis for switching to DSL2. Since we do not want to include all changes that are still necessary in one big PR, we will merge this for now in the dsl2 branch and adapt the remaining things afterwards. @ggabernet does that sound okay to you?

ggabernet
ggabernet approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member
@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright this basically deletes the whole pipeline though, but as discussed this morning a new PR is coming adding the modules right?

@christopher-mohr
Copy link
Collaborator Author

Alright this basically deletes the whole pipeline though, but as discussed this morning a new PR is coming adding the modules right?

I moved the content of the main.nf to epitopeprediction.nf and we will now add the processes/modules in separate PRs.

@christopher-mohr
Copy link
Collaborator Author

@ggabernet I just realised that the content of epitopeprediction.nf was not committed... everything should be there now again. :)

@christopher-mohr christopher-mohr merged commit b001306 into nf-core:dsl2 Oct 29, 2021
@github-actions
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --fix
    • Manually resolve anything left from markdownlint .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopher-mohr @ggabernet @nf-core-bot @KevinMenden
0