8000 Add threshold function for rank and set affinity as optional by jonasscheid · Pull Request #161 · nf-core/epitopeprediction · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add threshold function for rank and set affinity as optional #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 28, 2022
Merged

Add threshold function for rank and set affinity as optional #161

merged 9 commits into from
Jun 28, 2022

Conversation

jonasscheid
Copy link
Collaborator
@jonasscheid jonasscheid commented Jun 23, 2022 •
edited
Loading

Set rank as default threshold metric for netmhc tools and add option for affinity threshold

Fixing #160

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
github-actions bot commented Jun 23, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 6f1b1c9

+| ✅ 149 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-28 13:38:57

marissaDubbelaar
marissaDubbelaar approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor
@marissaDubbelaar marissaDubbelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopher-mohr
christopher-mohr requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator
@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Found two things that should be discussed/addressed and some minor things.

christopher-mohr
christopher-mohr approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator
@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christopher-mohr
Copy link
Collaborator

I just saw that the tests fail, could you have a look? Looks like something is wrong in epaa.py.

@christopher-mohr christopher-mohr merged commit ff3efda into nf-core:switch_to_epytope Jun 28, 2022
@jonasscheid jonasscheid mentioned this pull request Jul 1, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-mohr christopher-mohr christopher-mohr approved these changes

@marissaDubbelaar marissaDubbelaar marissaDubbelaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasscheid @christopher-mohr @marissaDubbelaar
0